Skip to content

feat: additional envars for customization #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krishnaGajabi wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: additional envars for customization #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions chart/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,8 +201,15 @@ This removes all the Kubernetes components associated with the chart and deletes
| io_engine.&ZeroWidthSpace;nodeSelector | Node selectors to designate storage nodes for diskpool creation Note that if multi-arch images support 'kubernetes.io/arch: amd64' should be removed. | <pre>{<br>"kubernetes.io/arch":"amd64",<br>"openebs.io/engine":"mayastor"<br>}</pre> |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;ioTimeout | Timeout for IOs The default here is exaggerated for local disks, but we've observed that in shared virtual environments having a higher timeout value is beneficial. Please adjust this according to your hardware and needs. | `"110s"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;rdma.&ZeroWidthSpace;bufCacheSize | The number of shared buffers to reserve for each poll group | `"64"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;rdma.&ZeroWidthSpace;dataWrPoolSize | RDMA data WR pool size (RDMA only) | `"4095"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;rdma.&ZeroWidthSpace;inCapsuleDataSize | Max number of in-capsule data size | `"4096"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;rdma.&ZeroWidthSpace;ioUnitSize | I/O unit size (bytes) | `"8192"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;rdma.&ZeroWidthSpace;maxIoSize | Max I/O size (bytes) | `"131072"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;rdma.&ZeroWidthSpace;numSharedBuf | The number of pooled data buffers available to the transport | `"2047"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;bufCacheSize | The number of shared buffers to reserve for each poll group | `"64"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;inCapsuleDataSize | Max number of in-capsule data size | `"4096"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;ioUnitSize | I/O unit size (bytes) | `"131072"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;maxIoSize | Max I/O size (bytes) | `"131072"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;maxQpairsPerCtrl | Max number of IO qpairs per controller | `"32"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;maxQueueDepth | You may need to increase this for a higher outstanding IOs per volume | `"32"` |
| io_engine.&ZeroWidthSpace;nvme.&ZeroWidthSpace;tcp.&ZeroWidthSpace;numSharedBuf | The number of pooled data buffers available to the transport | `"2047"` |
Expand Down
14 changes: 14 additions & 0 deletions chart/templates/mayastor/io/io-engine-daemonset.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,25 @@ spec:
value: "{{ .Values.io_engine.nvme.tcp.maxQpairsPerCtrl }}"
- name: NVMF_TCP_MAX_QUEUE_DEPTH
value: "{{ .Values.io_engine.nvme.tcp.maxQueueDepth }}"
- name: NVMF_TCP_IN_CAPSULE_DATA_SIZE
value: "{{ .Values.io_engine.nvme.tcp.inCapsuleDataSize }}"
- name: NVMF_TCP_MAX_IO_SIZE
value: "{{ .Values.io_engine.nvme.tcp.maxIoSize }}"
- name: NVMF_TCP_IO_UNIT_SIZE
value: "{{ .Values.io_engine.nvme.tcp.ioUnitSize }}"
{{- if .Values.io_engine.target.nvmf.rdma.enabled }}
- name: NVMF_RDMA_NUM_SHARED_BUF
value: "{{ .Values.io_engine.nvme.rdma.numSharedBuf }}"
- name: NVMF_RDMA_BUF_CACHE_SIZE
value: "{{ .Values.io_engine.nvme.rdma.bufCacheSize }}"
- name: NVMF_RDMA_DATA_WR_POOL_SIZE
value: "{{ .Values.io_engine.nvme.rdma.dataWrPoolSize }}"
- name: NVMF_RDMA_MAX_IO_SIZE
value: "{{ .Values.io_engine.nvme.rdma.maxIoSize }}"
- name: NVMF_RDMA_IO_UNIT_SIZE
value: "{{ .Values.io_engine.nvme.rdma.ioUnitSize }}"
- name: NVMF_RDMA_IN_CAPSULE_DATA_SIZE
value: "{{ .Values.io_engine.nvme.rdma.inCapsuleDataSize }}"
{{- end }}
- name: NVME_TIMEOUT
value: "{{ .Values.io_engine.nvme.ioTimeout }}"
Expand Down
14 changes: 14 additions & 0 deletions chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,11 +490,25 @@ io_engine:
numSharedBuf: "2047"
# -- The number of shared buffers to reserve for each poll group
bufCacheSize: "64"
# -- Max number of in-capsule data size
inCapsuleDataSize: "4096"
# -- Max I/O size (bytes)
maxIoSize: "131072"
# -- I/O unit size (bytes)
ioUnitSize: "131072"
rdma:
# -- The number of pooled data buffers available to the transport
numSharedBuf: "2047"
# -- The number of shared buffers to reserve for each poll group
bufCacheSize: "64"
# -- RDMA data WR pool size (RDMA only)
dataWrPoolSize: "4095"
# -- Max number of in-capsule data size
inCapsuleDataSize: "4096"
# -- Max I/O size (bytes)
maxIoSize: "131072"
# -- I/O unit size (bytes)
Comment on lines +504 to +510
Copy link
Copy Markdown
Member

@Abhinandan-Purkait Abhinandan-Purkait May 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this at seperate places? Why not common?

Copy link
Copy Markdown
Contributor Author

@krishnaGajabi krishnaGajabi May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its more structured this way ie separate setting for rdma and tcp
earlier only setting for tcp were defined.

ioUnitSize: "8192"
# -- Pass additional arguments to the Environment Abstraction Layer.
# Example: --set {product}.envcontext=iova-mode=pa
envcontext: ""
Expand Down
Loading