Fix quality errors

Author: UsamaSadiq

code_annotations/base.py

@@ -141,10 +141,10 @@ def _configure_coverage(self, coverage_target):
         if coverage_target:
             try:
                 self.coverage_target = float(coverage_target)
-            except (TypeError, ValueError):
+            except (TypeError, ValueError) as error:
                 raise ConfigurationException(
                     f'Coverage target must be a number between 0 and 100 not "{coverage_target}".'
-                )
+                ) from error
 
             if self.coverage_target < 0.0 or self.coverage_target > 100.0:
                 raise ConfigurationException(

code_annotations/contrib/sphinx/extensions/featuretoggles.py

@@ -4,7 +4,6 @@
 import os
 
 import pkg_resources
-
 from docutils import nodes
 from sphinx.util.docutils import SphinxDirective
 

code_annotations/contrib/sphinx/extensions/settings.py

@@ -4,7 +4,6 @@
 import os
 
 import pkg_resources
-
 from docutils import nodes
 from docutils.parsers.rst import directives
 from sphinx.util.docutils import SphinxDirective

code_annotations/extensions/base.py

@@ -77,7 +77,6 @@ def __init__(self, config, echo):
         if self.lang_comment_definition is None:  # pragma: no cover
             raise ValueError('Subclasses of SimpleRegexAnnotationExtension must define lang_comment_definition!')
 
-        # pylint: disable=not-a-mapping
         self.comment_regex = re.compile(
             self.comment_regex_fmt.format(**self.lang_comment_definition),
             flags=re.VERBOSE
@@ -124,13 +123,13 @@ def search(self, file_handle):
                     try:
                         annotation_token = inner_match.group('token')
                         annotation_data = inner_match.group('data')
-                    except IndexError:
+                    except IndexError as error:
                         # pragma: no cover
                         raise ValueError('{}::{}: Could not find "data" or "token" groups. Found: {}'.format(
                             fname,
                             line,
                             inner_match.groupdict()
-                        ))
+                        )) from error
                     annotation_token, annotation_data = clean_annotation(annotation_token, annotation_data)
                     found_annotations.append({
                         'found_by': self.extension_name,

code_annotations/find_django.py

@@ -119,12 +119,12 @@ def _append_model_annotations(self, model_type, model_id, query, model_annotatio
             try:
                 annotation_token = inner_match.group('token')
                 annotation_data = inner_match.group('data')
-            except IndexError:
+            except IndexError as error:
                 # pragma: no cover
                 raise ValueError('{}: Could not find "data" or "token" groups. Found: {}'.format(
                     self.get_model_id(model_type),
                     inner_match.groupdict()
-                ))
+                )) from error
             annotation_token, annotation_data = clean_annotation(annotation_token, annotation_data)
             model_annotations.append({
                 'found_by': "django",

tests/test_django_coverage.py

@@ -1,9 +1,10 @@
 """
 Tests for the DjangoSearch coverage functionality.
 """
-import pytest
 from unittest.mock import DEFAULT, patch
 
+import pytest
+
 from code_annotations.find_django import DjangoSearch
 from tests.fake_models import (
     FakeBaseModelAbstract,

tests/test_django_generate_safelist.py

@@ -3,9 +3,9 @@
 Tests for seeding the safelist.
 """
 import os
+from unittest.mock import DEFAULT, MagicMock, patch
 
 import pytest
-from unittest.mock import DEFAULT, MagicMock, patch
 
 from code_annotations.find_django import DjangoSearch
 from tests.helpers import DEFAULT_FAKE_SAFELIST_PATH, EXIT_CODE_FAILURE, EXIT_CODE_SUCCESS, call_script_isolated

tests/test_django_list_local_models.py

@@ -2,9 +2,10 @@
 """
 Tests for listing local models.
 """
-import pytest
 from unittest.mock import DEFAULT, MagicMock, patch
 
+import pytest
+
 from tests.helpers import call_script_isolated
 
 

tests/test_find_django.py

@@ -3,7 +3,6 @@
 Tests for find annotations in Django models.
 """
 import sys
-
 from unittest.mock import DEFAULT, patch
 
 from code_annotations.find_django import DjangoSearch

tox.ini

@@ -16,23 +16,23 @@ addopts = --cov code_annotations --cov-report term-missing --cov-report xml
 norecursedirs = .* docs requirements
 
 [testenv]
-deps = 
+deps =
 	django22: Django>=2.2,<2.3
 	django30: Django>=3.0,<3.1
 	django31: Django>=3.1,<3.2
 	-r{toxinidir}/requirements/test.txt
-commands = 
+commands =
 	python -Wd -m pytest {posargs}
 
 [testenv:docs]
-setenv = 
+setenv =
 	PYTHONPATH = {toxinidir}
-whitelist_externals = 
+whitelist_externals =
 	make
 	rm
-deps = 
+deps =
 	-r{toxinidir}/requirements/doc.txt
-commands = 
+commands =
 	doc8 --ignore-path docs/_build README.rst docs
 	rm -f docs/code_annotations.rst
 	rm -f docs/modules.rst
@@ -41,14 +41,14 @@ commands =
 	python setup.py check --restructuredtext --strict
 
 [testenv:quality]
-whitelist_externals = 
+whitelist_externals =
 	make
-deps = 
+deps =
 	-r{toxinidir}/requirements/quality.txt
-commands = 
+commands =
 	pylint code_annotations tests test_utils setup.py
 	pycodestyle code_annotations tests setup.py
 	pydocstyle code_annotations tests setup.py
-	isort --check-only --diff --recursive tests test_utils code_annotations setup.py
+	isort --check-only --diff tests test_utils code_annotations setup.py
 	make selfcheck