Skip to content

Commit 8bc7969

Browse files
authored
fix(vc): update obv3 achievement id format to urn compatible
1 parent 76fa5f0 commit 8bc7969

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

credentials/apps/verifiable_credentials/composition/open_badges.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class AchievementSchema(serializers.Serializer): # pylint: disable=abstract-met
1818

1919
TYPE = "Achievement"
2020

21-
id = serializers.CharField(source="user_credential.uuid")
21+
id = serializers.UUIDField(source="user_credential.uuid", format="urn")
2222
type = serializers.CharField(default=TYPE)
2323
name = serializers.CharField(source="credential_name")
2424
description = serializers.CharField(source="credential_description")

credentials/apps/verifiable_credentials/composition/tests/test_open_badges.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def test_credential_subject_achievement_id(self, program_issuance_line):
8282
"""
8383
Credential Subject Achievement `id` property.
8484
"""
85-
expected_id = str(program_issuance_line.user_credential.uuid)
85+
expected_id = f"urn:uuid:{program_issuance_line.user_credential.uuid}"
8686

8787
composed_obv3 = OpenBadgesDataModel(program_issuance_line).data
8888

0 commit comments

Comments
 (0)