Skip to content

Update because this xblock is going to be available by default on Teak#1078

Closed
SantiagoSuHe wants to merge 3 commits into
openedx:mainfrom
SantiagoSuHe:patch-1
Closed

Update because this xblock is going to be available by default on Teak#1078
SantiagoSuHe wants to merge 3 commits into
openedx:mainfrom
SantiagoSuHe:patch-1

Conversation

@SantiagoSuHe
Copy link
Copy Markdown
Contributor

No description provided.

@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @SantiagoSuHe!

This repository is currently maintained by @openedx/docs-openedx-org-maintainers.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Submit a signed contributor agreement (CLA)

⚠️ We ask all contributors to the Open edX project to submit a signed contributor agreement or indicate their institutional affiliation.
Please see the CONTRIBUTING file for more information.

If you've signed an agreement in the past, you may need to re-sign.
See The New Home of the Open edX Codebase for details.

Once you've signed the CLA, please allow 1 business day for it to be processed.
After this time, you can re-run the CLA check by adding a comment below that you have signed it.
If the CLA check continues to fail, you can tag the @openedx/cla-problems team in a comment for further assistance.

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label May 20, 2025
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions May 20, 2025
@sarina sarina changed the base branch from release/teak to main May 21, 2025 00:22
@sarina
Copy link
Copy Markdown
Contributor

sarina commented May 21, 2025

I wouldn't remove this because a lot of people don't run on the latest release. I'd simply add a note that this is default On in Teak but earlier releases require the following steps to enable the tool.

You also need to sign the CLA, see the bot's comments for instructions.

I decided to leave a comment in the “Enable” section to clarify that this XBlock is available by default, instead of simply removing the option.
@SantiagoSuHe SantiagoSuHe requested a review from jswope00 May 21, 2025 15:23
@sarina
Copy link
Copy Markdown
Contributor

sarina commented May 21, 2025

@SantiagoSuHe please let me know when you've signed the CLA. This needs to not delete the content you deleted, as well. It may be easier to just make a new PR.

@SantiagoSuHe
Copy link
Copy Markdown
Contributor Author

@sarina Just to clarify. Does each Open edX release have its own version of the documentation? If I’m using an older version of the platform, should I refer to the corresponding version of the docs?

@sarina
Copy link
Copy Markdown
Contributor

sarina commented May 21, 2025

Each release does have a version of the docs, but, many people don't know they need to use the switcher in the bottom right to see older versions:

image

@sarina
Copy link
Copy Markdown
Contributor

sarina commented May 21, 2025

Also by deleting the content you deleted, you broke some references. It's easier to just not delete that content for now.

@SantiagoSuHe
Copy link
Copy Markdown
Contributor Author

@sarina Got it, thanks for explaining!

@SantiagoSuHe
Copy link
Copy Markdown
Contributor Author

@sarina Would you mind helping me close this PR? I’ll submit a new one with an improved update.

@sarina sarina closed this May 21, 2025
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants