Skip to content

feat: add EnterpriseEnrollmentPostProcessor pipeline step for CourseEnrollmentStarted filter#2553

Open
pwnage101 wants to merge 2 commits into
masterfrom
pwnage101/ENT-11570
Open

feat: add EnterpriseEnrollmentPostProcessor pipeline step for CourseEnrollmentStarted filter#2553
pwnage101 wants to merge 2 commits into
masterfrom
pwnage101/ENT-11570

Conversation

@pwnage101
Copy link
Copy Markdown
Contributor

@pwnage101 pwnage101 commented Mar 5, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.03%. Comparing base (585472a) to head (4e4c906).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2553      +/-   ##
==========================================
+ Coverage   86.01%   86.03%   +0.01%     
==========================================
  Files         249      250       +1     
  Lines       16673    16695      +22     
  Branches     1655     1656       +1     
==========================================
+ Hits        14342    14364      +22     
  Misses       1997     1997              
  Partials      334      334              
Flag Coverage Δ
unittests 86.03% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kiram15 kiram15 force-pushed the pwnage101/ENT-11570 branch from a35d99d to ceabb63 Compare April 23, 2026 20:39
@kiram15 kiram15 requested a review from Copilot April 23, 2026 20:49
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an EnterpriseEnrollmentPostProcessor pipeline step to post enterprise enrollment + consent on course enrollment events, with accompanying unit tests.

Changes:

  • Introduces enterprise.filters.enrollment.EnterpriseEnrollmentPostProcessor pipeline step.
  • Adds unit tests covering enterprise vs non-enterprise paths and exception logging behavior.
  • Adds minimal tests/filters package init.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
enterprise/filters/enrollment.py New pipeline step that posts enterprise enrollment and consent, logging failures.
enterprise/filters/init.py Initializes enterprise.filters package.
tests/filters/test_enrollment.py New tests validating API client calls and exception logging.
tests/filters/init.py Initializes tests.filters package.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +28 to +39
def _make_openedx_modules():
"""
Build a minimal set of sys.modules entries for the openedx namespace.
"""
entries = {}
for name in (
"openedx",
"openedx.features",
"openedx.features.enterprise_support",
):
entries[name] = ModuleType(name)
return entries
Copy link

Copilot AI Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These ModuleType stubs won't behave like packages during import because they lack __path__. As a result, from openedx.features.enterprise_support.api import ... can fail with ModuleNotFoundError: 'openedx' is not a package in environments where openedx isn't installed. Fix by marking the namespace modules as packages (e.g., setting __path__ = [] on each) and/or wiring submodules as attributes on their parents so the import machinery can resolve the hierarchy.

Copilot uses AI. Check for mistakes.
Comment thread tests/filters/test_enrollment.py Outdated
Comment thread enterprise/filters/enrollment.py Outdated
@kiram15 kiram15 force-pushed the pwnage101/ENT-11570 branch 6 times, most recently from b8aef35 to 21f022a Compare April 27, 2026 18:53
@kiram15 kiram15 marked this pull request as ready for review April 27, 2026 19:36
@kiram15 kiram15 force-pushed the pwnage101/ENT-11570 branch from 21f022a to 67d3376 Compare April 27, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants