chore: pin GitHub Actions workflows to full commit SHAs#246
Open
irfanuddinahmad wants to merge 3 commits into
Open
chore: pin GitHub Actions workflows to full commit SHAs#246irfanuddinahmad wants to merge 3 commits into
irfanuddinahmad wants to merge 3 commits into
Conversation
farhan
approved these changes
May 19, 2026
farhan
approved these changes
May 19, 2026
|
@irfanuddinahmad looks like the PR is failing tests, probably unrelated, can you fix the issue anyway in a separate PR and then we can rebase this and land it. |
enmerkar 0.7.1 calls `from pkg_resources import get_distribution` in its __init__.py at runtime. pkg_resources ships with setuptools, which is no longer bundled with Python 3.12. Adding setuptools as an explicit requirement ensures it is available in the tox virtualenv. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
enmerkar 0.7.1 imports pkg_resources at module load time but does not declare setuptools as a dependency. In some virtualenv configurations, pkg_resources is not importable even when setuptools is installed. This conftest.py creates a minimal importlib.metadata-backed shim so that pytest collection succeeds regardless of the virtualenv setup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
feanil
reviewed
Jun 3, 2026
feanil
left a comment
feanil
left a comment
There was a problem hiding this comment.
Also, worth checking is where this library is being used, do we still need this fork?
| @@ -0,0 +1,34 @@ | |||
| """ | |||
| Ensure pkg_resources is importable before any tests run. | |||
There was a problem hiding this comment.
Why do we need both this shim and adding setuptools to the base.in? Can't we just update this library to use importlib.metadata instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins all
uses:action refs to their full commit SHA with the version tag preserved as a comment. Part of org-wide SHA-pinning migration: openedx/.github#165