fix: validate late enrollment course run metadata

Author: zwidekalanga

enterprise_subsidy/apps/api_client/enterprise.py

@@ -10,6 +10,7 @@
 
 from enterprise_subsidy.apps.api_client.base_oauth import BaseOAuthClient
 from enterprise_subsidy.apps.core.utils import localized_utcnow
+from enterprise_subsidy.apps.subsidy.constants import ALLOW_LATE_ENROLLMENT_KEY
 
 logger = logging.getLogger(__name__)
 
@@ -109,7 +110,7 @@ def enroll(self, lms_user_id, course_run_key, ledger_transaction):
         }
         # If late enrollment has been enabled for this transaction, inform the enterprise bulk enroll endpoint to bypass
         # any enrollment deadline validation.
-        if ledger_transaction.metadata and ledger_transaction.metadata.get('allow_late_enrollment', False):
+        if ledger_transaction.metadata and ledger_transaction.metadata.get(ALLOW_LATE_ENROLLMENT_KEY, False):
             enrollment_info['force_enrollment'] = True
         customer_uuid = ledger_transaction.ledger.subsidy.enterprise_customer_uuid
         response = self.bulk_enroll_enterprise_learners(customer_uuid, [enrollment_info])

enterprise_subsidy/apps/subsidy/constants.py

@@ -5,6 +5,9 @@
 # Numeric constants
 CENTS_PER_DOLLAR = 100
 
+# Transaction metadata keys
+ALLOW_LATE_ENROLLMENT_KEY = 'allow_late_enrollment'
+
 # System-wide roles defined by edx-enterprise, used across the entire openedx instance, and can be found in JWT tokens.
 SYSTEM_ENTERPRISE_LEARNER_ROLE = 'enterprise_learner'
 SYSTEM_ENTERPRISE_ADMIN_ROLE = 'enterprise_admin'

enterprise_subsidy/apps/subsidy/models.py

@@ -34,6 +34,7 @@
 from enterprise_subsidy.apps.core.utils import localized_utcnow
 from enterprise_subsidy.apps.fulfillment.api import GEAGFulfillmentHandler, is_geag_fulfillment
 from enterprise_subsidy.apps.fulfillment.exceptions import IncompleteContentMetadataException
+from enterprise_subsidy.apps.subsidy.constants import ALLOW_LATE_ENROLLMENT_KEY
 
 MOCK_CATALOG_CLIENT = mock.MagicMock()
 MOCK_ENROLLMENT_CLIENT = mock.MagicMock()
@@ -519,6 +520,12 @@ def redeem(
 
             # Fetch one or more metadata keys from catalog service, with overall metadata request locally cached.
             content_metadata_summary = self.metadata_summary_for_content(content_key)
+            is_late_enrollment = bool(metadata and metadata.get(ALLOW_LATE_ENROLLMENT_KEY))
+            if is_late_enrollment and not content_metadata_summary.get('course_run_key'):
+                raise ContentNotFoundForCustomerException(
+                    f'Late enrollment for {content_key} must resolve to a concrete course run. '
+                    'Use the exact course run key for custom or one-off presentations.'
+                )
             content_title = content_metadata_summary.get('content_title')
             parent_content_key = content_metadata_summary.get('content_key')
             course_run_start_date = content_metadata_summary.get('course_run_start_date')

enterprise_subsidy/apps/subsidy/tests/test_models.py

@@ -22,6 +22,7 @@
 from enterprise_subsidy.apps.content_metadata.constants import ProductSources
 from enterprise_subsidy.apps.fulfillment.api import InvalidFulfillmentMetadataException
 from enterprise_subsidy.apps.fulfillment.exceptions import IncompleteContentMetadataException
+from enterprise_subsidy.apps.subsidy.constants import ALLOW_LATE_ENROLLMENT_KEY
 from test_utils.utils import MockResponse
 
 from ..models import ContentNotFoundForCustomerException, PriceValidationError, Subsidy
@@ -472,6 +473,39 @@ def test_redeem_with_metadata(
         assert new_transaction.quantity == -mock_content_price
         assert new_transaction.metadata == tx_metadata
 
+    @mock.patch('enterprise_subsidy.apps.subsidy.models.Subsidy.price_for_content')
+    @mock.patch('enterprise_subsidy.apps.subsidy.models.Subsidy.enterprise_client')
+    @mock.patch("enterprise_subsidy.apps.content_metadata.api.ContentMetadataApi.get_content_summary")
+    def test_redeem_late_enrollment_requires_resolved_course_run(
+        self, mock_get_content_summary, mock_enterprise_client, mock_price_for_content
+    ):
+        """
+        Late enrollment should not attempt LMS enrollment when catalog metadata has no concrete run.
+        """
+        lms_user_id = 1
+        content_key = "edX+test"
+        subsidy_access_policy_uuid = str(uuid4())
+        mock_get_content_summary.return_value = {
+            'content_uuid': 'edX+test',
+            'content_key': 'edX+test',
+            'content_title': 'edx: Test Course',
+            'source': 'edX',
+            'mode': 'verified',
+            'content_price': 10000,
+            'geag_variant_id': None,
+        }
+        mock_price_for_content.return_value = 1000
+
+        with self.assertRaisesRegex(ContentNotFoundForCustomerException, 'exact course run key'):
+            self.subsidy.redeem(
+                lms_user_id,
+                content_key,
+                subsidy_access_policy_uuid,
+                metadata={ALLOW_LATE_ENROLLMENT_KEY: True},
+            )
+
+        mock_enterprise_client.enroll.assert_not_called()
+
     @mock.patch('enterprise_subsidy.apps.subsidy.models.is_geag_fulfillment', return_value=True)
     @mock.patch('enterprise_subsidy.apps.subsidy.models.Subsidy.price_for_content')
     @mock.patch('enterprise_subsidy.apps.subsidy.models.Subsidy.enterprise_client')