fix: validate late enrollment course run metadata#436
Open
zwidekalanga wants to merge 2 commits into
Open
Conversation
3 tasks
zwidekalanga
force-pushed
the
cnx/late-enrollment-custom-presentations
branch
from
ae398dc to
c7af1ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent late enrollment redemptions from progressing to LMS force enrollment when catalog metadata does not resolve to a concrete course run.
This keeps the existing
allow_late_enrollmentbehavior, moves the metadata key behind a shared constant, and adds an explicit error telling operators to use the exact course run key for custom or one-off presentations.Related PRs
Testing instructions
python -m pip install Django==4.2.21 openedx-ledger==1.5.23 getsmarter-api-clients==0.6.3pytest enterprise_subsidy/apps/subsidy/tests/test_models.py::SubsidyModelRedemptionTestCase::test_redeem_late_enrollment_requires_resolved_course_run enterprise_subsidy/apps/api_client/tests/test_enterprise.py::EnterpriseApiClientTests::test_successful_create_single_learner_enrollment_forcedpython -m py_compile enterprise_subsidy/apps/subsidy/constants.py enterprise_subsidy/apps/api_client/enterprise.py enterprise_subsidy/apps/subsidy/models.py enterprise_subsidy/apps/subsidy/tests/test_models.pygit diff --checkMerge checklist