Skip to content

Commit 5c33b1f

Browse files
committed
fix: removed unsupported account level and web channel preferences in teak
1 parent 3c27d01 commit 5c33b1f

4 files changed

Lines changed: 10 additions & 17 deletions

File tree

src/notification-preferences/NotificationCoursesDropdown.jsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -61,9 +61,8 @@ const NotificationCoursesDropdown = () => {
6161
</Dropdown.Menu>
6262
</Dropdown>
6363
<span className="x-small text-gray-500">
64-
{selectedCourse?.name === 'Account'
65-
? intl.formatMessage(messages.notificationDropdownApplies)
66-
: intl.formatMessage(messages.notificationCourseDropdownApplies)}
64+
{selectedCourse?.name === 'Select Course'
65+
&& intl.formatMessage(messages.notificationDropdownSelectCourse)}
6766
</span>
6867
</div>
6968
)

src/notification-preferences/NotificationSettings.jsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,6 @@ const NotificationSettings = () => {
2222
<h2 className="notification-heading mb-3">
2323
{intl.formatMessage(messages.notificationHeading)}
2424
</h2>
25-
<div className="text-gray-700 font-size-14 mb-3">
26-
{intl.formatMessage(messages.accountNotificationDescription)}
27-
</div>
2825
<div className="text-gray-700 font-size-14 mb-3">
2926
{intl.formatMessage(messages.notificationCadenceDescription, {
3027
dailyTime: '22:00 UTC',
@@ -43,7 +40,9 @@ const NotificationSettings = () => {
4340
</Hyperlink>
4441
</div>
4542
<NotificationCoursesDropdown />
46-
<NotificationPreferences courseId={courseId} />
43+
{courseId && (
44+
<NotificationPreferences courseId={courseId} />
45+
)}
4746
<div className="border border-light-700 my-6" />
4847
</Container>
4948
)

src/notification-preferences/data/reducers.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export const defaultState = {
1111
showPreferences: false,
1212
courses: {
1313
status: IDLE_STATUS,
14-
courses: [],
14+
courses: [{ id: '', name: 'Select Course' }],
1515
pagination: {},
1616
},
1717
preferences: {

src/notification-preferences/messages.js

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -110,15 +110,10 @@ const messages = defineMessages({
110110
defaultMessage: 'Select notifications for',
111111
description: 'Dropdown label',
112112
},
113-
notificationDropdownApplies: {
114-
id: 'notification.dropdown.applies',
115-
defaultMessage: 'Applies to all courses',
116-
description: 'Dropdown applies to all courses',
117-
},
118-
notificationCourseDropdownApplies: {
119-
id: 'notification.dropdown.course.applies',
120-
defaultMessage: 'Overrides account-wide settings',
121-
description: 'Dropdown applies to specific course',
113+
notificationDropdownSelectCourse: {
114+
id: 'notification.dropdown.select.course',
115+
defaultMessage: 'Select a course you’re enrolled in to view its notification preferences.',
116+
description: 'Dropdown description',
122117
},
123118
});
124119

0 commit comments

Comments
 (0)