fix: addressing pr comments

Author: jacobo-dominguez-wgu

src/authz-module/audit-user/index.test.tsx

@@ -254,7 +254,7 @@ describe('AuditUserPage', () => {
       // Look for pagination controls
       expect(screen.getByRole('navigation', { name: /table pagination/i })).toBeInTheDocument();
       // Check that some users count is shown (format might vary)
-      expect(screen.getByText(/showing.*users/i)).toBeInTheDocument();
+      expect(screen.getByText(/showing/i)).toBeInTheDocument();
     });
   });
 

src/authz-module/audit-user/utils.test.tsx

@@ -55,7 +55,7 @@ describe('TableFooter', () => {
     it('displays correct showing text with current page items', () => {
       renderFooter();
 
-      expect(screen.getByText('Showing 3 of 42 users.')).toBeInTheDocument();
+      expect(screen.getByText('Showing 3 of 42.')).toBeInTheDocument();
     });
 
     it('displays showing text with different row count', () => {
@@ -70,7 +70,7 @@ describe('TableFooter', () => {
         itemCount: 100,
       });
 
-      expect(screen.getByText('Showing 5 of 100 users.')).toBeInTheDocument();
+      expect(screen.getByText('Showing 5 of 100.')).toBeInTheDocument();
     });
 
     it('displays showing text when on last page with fewer items', () => {
@@ -83,7 +83,7 @@ describe('TableFooter', () => {
         itemCount: 42,
       });
 
-      expect(screen.getByText('Showing 2 of 42 users.')).toBeInTheDocument();
+      expect(screen.getByText('Showing 2 of 42.')).toBeInTheDocument();
     });
   });
 
@@ -157,7 +157,7 @@ describe('TableFooter', () => {
         itemCount: 3,
       });
 
-      expect(screen.getByText('Showing 3 of 3 users.')).toBeInTheDocument();
+      expect(screen.getByText('Showing 3 of 3.')).toBeInTheDocument();
 
       const page1Button = screen.queryByRole('button', { name: /1 of 1/ });
       expect(page1Button).not.toBeInTheDocument();
@@ -174,7 +174,7 @@ describe('TableFooter', () => {
         },
       });
 
-      expect(screen.getByText('Showing 0 of 0 users.')).toBeInTheDocument();
+      expect(screen.getByText('Showing 0 of 0.')).toBeInTheDocument();
     });
 
     it('handles large page counts correctly', () => {
@@ -189,7 +189,7 @@ describe('TableFooter', () => {
 
       const currentPageButton = screen.getByRole('button', { name: '6 of 10' });
       expect(currentPageButton).toBeInTheDocument();
-      expect(screen.getByText('Showing 3 of 95 users.')).toBeInTheDocument();
+      expect(screen.getByText('Showing 3 of 95.')).toBeInTheDocument();
     });
   });
 });

src/authz-module/audit-user/utils.tsx

@@ -19,7 +19,7 @@ const Footer = () => {
         variant="reduced"
         currentPage={pageIndex + 1}
         pageCount={pageCount}
-        paginationLabel="Table pagination"
+        paginationLabel={formatMessage(messages['authz.table.footer.pagination.label'])}
         onPageSelect={(pageNum) => gotoPage(pageNum - 1)}
       />
     </TableFooter>

src/authz-module/components/TableFooter/TableFooter.test.tsx

@@ -167,40 +167,10 @@ const messages = defineMessages({
     defaultMessage: 'View all permissions',
     description: 'Text for the link to view all permissions in the user table',
   },
-  'authz.table.footer.items.showing.text': {
-    id: 'authz.table.footer.items.showing.text',
-    defaultMessage: 'Showing {pageSize} of {itemCount} users.',
-    description: 'Message displayed when the user reaches the applied filters limit',
-  },
-  'authz.table.controlbar.clearFilters': {
-    id: 'authz.table.controlbar.clearFilters',
-    defaultMessage: 'Clear filters',
-    description: 'Button to clear all active filters in the table',
-  },
-  'authz.table.controlbar.search': {
-    id: 'authz.table.controlbar.search',
-    defaultMessage: 'Search',
-    description: 'Search placeholder for two specific fields',
-  },
-  'authz.table.controlbar.search.by.fields': {
-    id: 'authz.table.controlbar.search.by.fields',
-    defaultMessage: 'Search by {firstField} or {secondField}',
-    description: 'Search placeholder for two specific fields',
-  },
-  'authz.table.controlbar.filterby.label': {
-    id: 'authz.table.controlbar.filterby.label',
-    defaultMessage: 'Filtered by: ',
-    description: 'Label for active filters in the table',
-  },
-  'authz.table.controlbar.filters.limit.reached': {
-    id: 'authz.table.controlbar.filters.limit.reached',
-    defaultMessage: '10 filter limit reached. Remove one of the applied filters so you can select another one.',
-    description: 'Message displayed when the user reaches the applied filters limit',
-  },
-  'authz.table.controlbar.filters.items.showing': {
-    id: 'authz.table.controlbar.filters.items.showing',
-    defaultMessage: 'Showing {current} of {total}.',
-    description: 'Message displayed when the user reaches the applied filters limit',
+  'authz.table.footer.pagination.label': {
+    id: 'authz.table.footer.pagination.label',
+    defaultMessage: 'Table pagination',
+    description: 'Label for the table pagination controls',
   },
 });