Skip to content

Commit 3cd0cfd

Browse files
committed
refactor: consolidate permision constants in one place
1 parent 5fe0030 commit 3cd0cfd

10 files changed

Lines changed: 42 additions & 524 deletions

File tree

src/authz-module/components/UserPermissions.test.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { initializeMockApp } from '@edx/frontend-platform/testing';
22
import { renderWrapper } from '@src/setupTest';
3-
import * as coursesConstants from '@src/authz-module/constants';
3+
import * as coursesConstants from '@src/authz-module/roles-permissions';
44
import UserPermissions from './UserPermissions';
55

66
jest.mock('./RenderPermissionInLine', () => (
@@ -88,7 +88,8 @@ describe('UserPermissions', () => {
8888
];
8989

9090
const originalRolesObject = coursesConstants.rolesObject;
91-
(coursesConstants as any).rolesObject = [...originalRolesObject, ...mockRoleObject];
91+
const rolesObjectSpy = jest.spyOn(coursesConstants, 'rolesObject', 'get')
92+
.mockReturnValue([...originalRolesObject, ...mockRoleObject] as typeof originalRolesObject);
9293

9394
const props = {
9495
row: {
@@ -100,7 +101,7 @@ describe('UserPermissions', () => {
100101

101102
const { getByTestId } = renderWrapper(<UserPermissions {...props} />);
102103
expect(getByTestId('render-permission-inline')).toBeInTheDocument();
103-
(coursesConstants as any).rolesObject = originalRolesObject;
104+
rolesObjectSpy.mockRestore();
104105
});
105106

106107
it('returns null when role is not found in rolesObject (line 52 coverage)', () => {

src/authz-module/components/UserPermissions.tsx

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
1+
import { DJANGO_MANAGED_ROLES } from '@src/authz-module/constants';
12
import {
23
courseResourceTypes,
34
coursePermissions,
45
rolesObject,
5-
DJANGO_MANAGED_ROLES,
6-
} from '@src/authz-module/constants';
7-
import {
86
libraryResourceTypes,
97
libraryPermissions,
108
rolesLibraryObject,
11-
} from '@src/authz-module/roles-permissions/library/constants';
9+
} from '@src/authz-module/roles-permissions';
1210
import RenderPermissionColumn, { type PermissionItem } from './RenderPermissionColumn';
1311
import RenderPermissionInLine from './RenderPermissionInLine';
1412
import RenderAdminRole from './RenderAdminRole';

0 commit comments

Comments
 (0)