refactor: address feedback

Author: bra-i-am

src/authz-module/components/TableControlBar/ScopesFilter.test.tsx

@@ -101,11 +101,11 @@ describe('ScopesFilter', () => {
     );
   });
 
-  it('defaults to showing all scopes while permissions are loading', () => {
-    mockUsePermissions.mockReturnValue({ data: undefined });
+  it('defaults to showing only library scopes while permissions are loading', () => {
+    mockUsePermissions.mockReturnValue({ data: undefined, isLoading: true });
     renderWrapper(<ScopesFilter {...defaultProps} />);
     expect(mockUseScopes).toHaveBeenCalledWith(
-      expect.not.objectContaining({ scopeType: 'library' }),
+      expect.objectContaining({ scopeType: 'library' }),
     );
   });
 });

src/authz-module/hooks/useViewTeamPermissions.ts

@@ -8,11 +8,11 @@ export const useViewTeamPermissions = () => {
 
   const isCourseViewAllowed = permissions
     ? permissions.some((p) => p.action === CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_TEAM && p.allowed)
-    : true;
+    : false;
 
   const isLibraryViewAllowed = permissions
     ? permissions.some((p) => p.action === CONTENT_LIBRARY_PERMISSIONS.VIEW_LIBRARY_TEAM && p.allowed)
-    : true;
+    : false;
 
   return { isCourseViewAllowed, isLibraryViewAllowed, isLoading };
 };

src/authz-module/team-members/TeamMembersTable.test.tsx

@@ -2,6 +2,7 @@ import { screen, waitFor } from '@testing-library/react';
 import userEvent from '@testing-library/user-event';
 import { renderWithAllProviders } from '@src/setupTest';
 import { useAllRoleAssignments, useOrgs, useScopes } from '@src/authz-module/data/hooks';
+import type { GetAllRoleAssignmentsResponse } from '@src/authz-module/data/api';
 import { useViewTeamPermissions } from '@src/authz-module/hooks/useViewTeamPermissions';
 import { LIBRARY_ROLE_KEYS } from '@src/authz-module/roles-permissions';
 import { ToastManagerProvider } from '@src/components/ToastManager/ToastManagerContext';
@@ -13,7 +14,12 @@ jest.mock('@src/authz-module/hooks/useViewTeamPermissions', () => ({
 
 const mockUseViewTeamPermissions = useViewTeamPermissions as jest.Mock;
 
-const mockedAllRoleAssignments = {
+const mockedAllRoleAssignments: {
+  data: GetAllRoleAssignmentsResponse | undefined;
+  error: Error | null;
+  isLoading: boolean;
+  refetch: jest.Mock;
+} = {
   data: {
     results: [
       {
@@ -208,7 +214,6 @@ describe('TeamMembersTable', () => {
   });
 
   it('renders safely when role assignments data is undefined', () => {
-    // @ts-ignore
     mockApiResponses({ ...mockedAllRoleAssignments, data: undefined });
     renderWithAllProviders(<ToastManagerProvider><TeamMembersTable /></ToastManagerProvider>);
     expect(screen.queryByText('John Doe')).not.toBeInTheDocument();

src/authz-module/team-members/TeamMembersTable.tsx

@@ -20,7 +20,6 @@ import {
 } from '@src/authz-module/components/TableCells';
 import { useAllRoleAssignments } from '@src/authz-module/data/hooks';
 import { TABLE_DEFAULT_PAGE_SIZE } from '@src/authz-module/constants';
-import { UserRole } from '@src/types';
 import messages from './messages';
 import TableFooter from '../components/TableFooter/TableFooter';
 
@@ -54,7 +53,7 @@ const TeamMembersTable = ({ presetScope }: TeamMembersTableProps) => {
   }, [isCourseViewAllowed, querySettings]);
 
   const {
-    data: { results: roleAssignments, count } = { results: [] as UserRole[], count: 0 },
+    data: { results: roleAssignments, count } = { results: [], count: 0 },
     isLoading: isLoadingAllRoleAssignments,
     error,
     refetch,