refactor: add a teams manage variable

Author: dcoa

src/authz-module/components/AddRoleButton.tsx

@@ -6,7 +6,7 @@ import { useNavigate } from 'react-router-dom';
 import baseMessages from '@src/authz-module/messages';
 import { buildWizardPath } from '@src/authz-module/constants';
 import { useValidateUserPermissionsNonSuspense } from '@src/data/hooks';
-import { CONTENT_COURSE_PERMISSIONS, CONTENT_LIBRARY_PERMISSIONS } from '../roles-permissions';
+import { MANAGE_TEAM_PERMISSIONS } from '../roles-permissions';
 
 interface AddRoleButtonProps {
   presetUsername?: string;
@@ -17,10 +17,7 @@ const AddRoleButton = ({ presetUsername, from }: AddRoleButtonProps) => {
   const intl = useIntl();
   const navigate = useNavigate();
 
-  const { data: permissionValidationResponse } = useValidateUserPermissionsNonSuspense([
-    { action: CONTENT_LIBRARY_PERMISSIONS.MANAGE_LIBRARY_TEAM },
-    { action: CONTENT_COURSE_PERMISSIONS.MANAGE_COURSE_TEAM },
-  ]);
+  const { data: permissionValidationResponse } = useValidateUserPermissionsNonSuspense(MANAGE_TEAM_PERMISSIONS);
   const canAssignRole = permissionValidationResponse?.some((permission) => permission.allowed);
 
   const handleClick = () => {

src/authz-module/components/TableControlBar/RolesFilter.tsx

@@ -3,6 +3,7 @@ import { useIntl } from '@edx/frontend-platform/i18n';
 import { Person } from '@openedx/paragon/icons';
 import { useValidateUserPermissionsNonSuspense } from '@src/data/hooks';
 import { CONTENT_COURSE_PERMISSIONS, CONTENT_LIBRARY_PERMISSIONS } from '@src/authz-module/roles-permissions';
+import { CONTEXT_TYPES } from '@src/authz-module/constants';
 import MultipleChoiceFilter from './MultipleChoiceFilter';
 import { MultipleChoiceFilterProps } from './types';
 import { getRolesFiltersOptions } from '../constants';
@@ -24,8 +25,8 @@ const RolesFilter = ({
     const contexts = new Set<string>();
     permissions?.forEach((p) => {
       if (!p.allowed) { return; }
-      if (p.action === CONTENT_LIBRARY_PERMISSIONS.VIEW_LIBRARY_TEAM) { contexts.add('library'); }
-      if (p.action === CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_TEAM) { contexts.add('course'); }
+      if (p.action === CONTENT_LIBRARY_PERMISSIONS.VIEW_LIBRARY_TEAM) { contexts.add(CONTEXT_TYPES.LIBRARY); }
+      if (p.action === CONTENT_COURSE_PERMISSIONS.VIEW_COURSE_TEAM) { contexts.add(CONTEXT_TYPES.COURSE); }
     });
     return contexts;
   }, [permissions]);

src/authz-module/constants.ts

@@ -67,9 +67,9 @@ export const DEFAULT_FILTER_PAGE_SIZE = 5;
 export const ADMIN_ROLES = ['course_admin', 'library_admin'];
 
 // Resource Type Definitions
-export const RESOURCE_TYPES = {
+export const CONTEXT_TYPES = {
   LIBRARY: 'library',
   COURSE: 'course',
 } as const;
 
-export type ResourceType = typeof RESOURCE_TYPES[keyof typeof RESOURCE_TYPES];
+export type ResourceType = typeof CONTEXT_TYPES[keyof typeof CONTEXT_TYPES];

src/authz-module/role-assignation-wizard/AssignRoleWizardPage.tsx

@@ -7,6 +7,7 @@ import { ROUTES } from '../constants';
 import messages from './messages';
 import {
   CONTENT_COURSE_PERMISSIONS, CONTENT_LIBRARY_PERMISSIONS, courseRolesMetadata, libraryRolesMetadata,
+  MANAGE_TEAM_PERMISSIONS,
 } from '../roles-permissions';
 
 const AssignRoleWizardPage = () => {
@@ -22,10 +23,7 @@ const AssignRoleWizardPage = () => {
     ? `${ROUTES.HOME_PATH}/user/${presetUser}`
     : returnTo;
 
-  const { data: permissionValidationResponse } = useValidateUserPermissionsNonSuspense([
-    { action: CONTENT_LIBRARY_PERMISSIONS.MANAGE_LIBRARY_TEAM },
-    { action: CONTENT_COURSE_PERMISSIONS.MANAGE_COURSE_TEAM },
-  ]);
+  const { data: permissionValidationResponse } = useValidateUserPermissionsNonSuspense(MANAGE_TEAM_PERMISSIONS);
 
   const rolesAssignable = permissionValidationResponse?.flatMap((p) => {
     if (!p.allowed) { return []; }

src/authz-module/roles-permissions/RolesPermissions.test.tsx

@@ -16,27 +16,6 @@ jest.mock('./library/utils', () => ({
   ]),
 }));
 
-// Mock constants
-jest.mock('./course/constants', () => ({
-  rolesObject: [
-    {
-      name: 'Course Admin', role: 'admin', permissions: [], userCount: 1,
-    },
-  ],
-  coursePermissions: [],
-  courseResourceTypes: [],
-}));
-
-jest.mock('./library/constants', () => ({
-  rolesLibraryObject: [
-    {
-      name: 'Library Admin', role: 'admin', permissions: [], userCount: 1,
-    },
-  ],
-  libraryPermissions: [],
-  libraryResourceTypes: [],
-}));
-
 jest.mock('@openedx/paragon', () => ({
   ...jest.requireActual('@openedx/paragon'),
   Hyperlink: ({ children, ...props }:

src/authz-module/roles-permissions/index.ts

@@ -1,3 +1,6 @@
+import { CONTENT_COURSE_PERMISSIONS } from './course/constants';
+import { CONTENT_LIBRARY_PERMISSIONS } from './library/constants';
+
 export {
   CONTENT_LIBRARY_PERMISSIONS,
   libraryResourceTypes,
@@ -13,3 +16,8 @@ export {
   rolesObject,
   courseRolesMetadata,
 } from './course/constants';
+
+export const MANAGE_TEAM_PERMISSIONS: { action: string }[] = [
+  { action: CONTENT_LIBRARY_PERMISSIONS.MANAGE_LIBRARY_TEAM },
+  { action: CONTENT_COURSE_PERMISSIONS.MANAGE_COURSE_TEAM },
+];