fix: remove empty strings from the user input

Author: dcoa

src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberTrigger.test.tsx

@@ -133,8 +133,8 @@ describe('AddNewTeamMemberTrigger', () => {
     const [, { onSuccess }] = mockMutate.mock.calls[0];
     onSuccess({
       completed: [
-        { user: 'alice@example.com', status: 'role_added' },
-        { user: 'bob@example.com', status: 'added_to_team' },
+        { userIdentifier: 'alice@example.com', status: 'role_added' },
+        { userIdentifier: 'bob@example.com', status: 'added_to_team' },
       ],
       errors: [],
     });
@@ -160,10 +160,10 @@ describe('AddNewTeamMemberTrigger', () => {
     const [, { onSuccess }] = mockMutate.mock.calls[0];
     onSuccess({
       completed: [
-        { user: 'alice@example.com', status: 'role_added' },
+        { userIdentifier: 'alice@example.com', status: 'role_added' },
       ],
       errors: [
-        { user: 'unknown@example.com', error: 'user_not_found' },
+        { userIdentifier: 'unknown@example.com', error: 'user_not_found' },
       ],
     });
 
@@ -191,8 +191,8 @@ describe('AddNewTeamMemberTrigger', () => {
     onSuccess({
       completed: [],
       errors: [
-        { user: 'unknown1@example.com', error: 'user_not_found' },
-        { user: 'unknown2@example.com', error: 'user_not_found' },
+        { userIdentifier: 'unknown1@example.com', error: 'user_not_found' },
+        { userIdentifier: 'unknown2@example.com', error: 'user_not_found' },
       ],
     });
 
@@ -222,7 +222,7 @@ describe('AddNewTeamMemberTrigger', () => {
     // Simulate successful response with no errors
     const [, { onSuccess }] = mockMutate.mock.calls[0];
     onSuccess({
-      completed: [{ user: 'alice@example.com', status: 'role_added' }],
+      completed: [{ userIdentifier: 'alice@example.com', status: 'role_added' }],
       errors: [],
     });
 
@@ -249,7 +249,7 @@ describe('AddNewTeamMemberTrigger', () => {
     // Simulate successful response
     const [, { onSuccess }] = mockMutate.mock.calls[0];
     onSuccess({
-      completed: [{ user: 'alice@example.com', status: 'role_added' }],
+      completed: [{ userIdentifier: 'alice@example.com', status: 'role_added' }],
       errors: [],
     });
 

src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberTrigger.tsx

@@ -44,7 +44,7 @@ const AddNewTeamMemberTrigger: FC<AddNewTeamMemberTriggerProps> = ({
   const handleErrors = (errors: PutAssignTeamMembersRoleResponse['errors']) => {
     setIsError(false);
     const notFoundUsers = errors.filter(err => err.error === RoleOperationErrorStatus.USER_NOT_FOUND)
-      .map(err => err.userIdentifier);
+      .map(err => err.userIdentifier.trim());
 
     if (errors.length === 1 && errors[0].error === RoleOperationErrorStatus.USER_ALREADY_HAS_ROLE) {
       setFormValues(DEFAULT_FORM_VALUES);
@@ -55,12 +55,9 @@ const AddNewTeamMemberTrigger: FC<AddNewTeamMemberTriggerProps> = ({
       setIsError(true);
       setFormValues((prev) => ({
         ...prev,
-        users: prev.users
-          .split(',')
-          .map(user => user.trim())
-          .filter(user => notFoundUsers.includes(user))
-          .join(', '),
+        users: notFoundUsers.join(', '),
       }));
+
       setAdditionMessage((prevMessage) => (
         `${prevMessage ? `${prevMessage} ` : ''}${intl.formatMessage(
           messages['libraries.authz.manage.add.member.failure'],
@@ -72,8 +69,9 @@ const AddNewTeamMemberTrigger: FC<AddNewTeamMemberTriggerProps> = ({
   };
 
   const handleAddTeamMember = () => {
+    const normalizedUsers = new Set(formValues.users.split(',').map(user => user.trim()).filter(user => user));
     const data = {
-      users: formValues.users.split(',').map(user => user.trim()),
+      users: [...normalizedUsers],
       role: formValues.role,
       scope: libraryId,
     };