Skip to content

fix: update app type declaration#133

Merged
dcoa merged 7 commits into
openedx:masterfrom
eduNEXT:dcoa/fix-type-val
Jun 12, 2026
Merged

fix: update app type declaration#133
dcoa merged 7 commits into
openedx:masterfrom
eduNEXT:dcoa/fix-type-val

Conversation

@dcoa

@dcoa dcoa commented Apr 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Tighten TypeScript coverage across the authz module and enable type validation in CI.

CI

  • .github/workflows/ci.yml — added npm run types (tsc --noEmit) step between Lint and Test

tsconfig

  • tsconfig.json — cleaned up config, added ignoreDeprecations: "6.0" to quiet TS 6.0 deprecation warnings on inherited options, This is temporal and mostly serves as the tsconfig.json file for compilerOptions.

Option 'moduleResolution=node10' is deprecated and will stop functioning in TypeScript 7.0. Specify compilerOption '"ignoreDeprecations": "6.0"' to silence this error.

  • dropped obsolete baseUrl + wildcard * path, kept @src/* alias

@arbrandes could you please help me to review the chore changes? I want to make sure the tsconfig is still correct and following the best practices. Thank you : )

Other changes

  • Remove duplicated test cases (in hooks)
  • Remove duplicated constants (courses / libraries)

This was a risk identified during the PRs review for the module refactor.

Please, @bra-i-am , @jesusbalderramawgu and @jacobo-dominguez-wgu review carefully that all is still working as expected, and if you find out another duplication fell free to open an issue or PR so we clean up the code together ;)

Assumptions

  • RoleCard is not needed as the new UI only displays the Permissions Table

    Test plan

    • npm run types passes
    • npm run lint passes
    • npm run test passes
    • CI runs the new Types step

LLM usage notice

Built with assistance from Claude.

@openedx-webhooks

openedx-webhooks commented Apr 19, 2026

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 19, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 19, 2026
@dcoa dcoa changed the title fix type issues fix: update app type declaration Apr 19, 2026
@dcoa dcoa marked this pull request as draft April 19, 2026 05:22
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 22, 2026
@dcoa dcoa force-pushed the dcoa/fix-type-val branch from 3ccc809 to ceeb84a Compare May 9, 2026 13:19
@codecov

codecov Bot commented May 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.50%. Comparing base (12b5783) to head (73e3467).

Files with missing lines Patch % Lines
src/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   97.64%   97.50%   -0.14%     
==========================================
  Files          68       66       -2     
  Lines        1572     1525      -47     
  Branches      396      388       -8     
==========================================
- Hits         1535     1487      -48     
- Misses         37       38       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa force-pushed the dcoa/fix-type-val branch from 7064476 to 38dbc68 Compare May 9, 2026 13:52
@dcoa dcoa marked this pull request as ready for review May 9, 2026 22:36
@arbrandes

Copy link
Copy Markdown
Contributor

I'm probably not going to get to this before the conference, but I'll do my best!

@bra-i-am bra-i-am left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcoa, thanks a lot for this PR, it's a pretty nice effort to improve the code quality!

I left some comments, and I'll be waiting for you to rebase this with master to test if everything keeps working as expected.

Comment thread src/authz-module/components/RenderPermissionColumn.tsx Outdated
Comment thread src/authz-module/roles-permissions/library/utils.test.ts Outdated
Comment thread src/setupTest.tsx
Comment thread src/authz-module/audit-user/index.test.tsx Outdated
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to In Eng Review in Contributions Jun 1, 2026
@dcoa dcoa force-pushed the dcoa/fix-type-val branch from 73e3467 to b04c19e Compare June 9, 2026 02:01
@dcoa

dcoa commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

@bra-i-am all the comments are addressed

@dcoa dcoa requested a review from bra-i-am June 9, 2026 02:05
@dcoa dcoa force-pushed the dcoa/fix-type-val branch from b04c19e to 1da88bc Compare June 10, 2026 00:52

@bra-i-am bra-i-am left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for this PR and for addressing my comments ✨

@dcoa

dcoa commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

I am proceeding to merge this. @bra-i-am thank for your help testing.

@dcoa dcoa merged commit 062574c into openedx:master Jun 12, 2026
3 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Jun 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants