Skip to content

feat: drop global roles from role filter #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mariajgrimaldi wants to merge 1 commit into from
Closed

feat: drop global roles from role filter #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/authz-module/components/TableControlBar/TableControlBar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@ describe('TableControlBar', () => {
const rolesButton = screen.getByText('Select Roles');
expect(rolesButton).toBeInTheDocument();
await user.click(rolesButton);
const superAdminOption = screen.getByRole('checkbox', { name: /Super Admin/i });
expect(superAdminOption).toBeInTheDocument();
await user.click(superAdminOption);
const courseAdminOption = screen.getByRole('checkbox', { name: /Course Admin/i });
expect(courseAdminOption).toBeInTheDocument();
await user.click(courseAdminOption);
expect(contextWithRolesFilter.columns[0].setFilter).toHaveBeenCalled();
});

Expand Down
13 changes: 0 additions & 13 deletions src/authz-module/components/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,19 +3,6 @@ import { Language, LibraryBooks, School } from '@openedx/paragon/icons';
import messages from './messages';

export const getRolesFiltersOptions = (intl: IntlShape) => [
{
groupName: intl.formatMessage(messages['authz.team.members.table.group.global']),
groupIcon: Language,
displayName: 'Super Admin',
value: 'super_admin',
},
{
groupName: intl.formatMessage(messages['authz.team.members.table.group.global']),
groupIcon: Language,
displayName: 'Global Staff',
value: 'global_staff',
},

{
groupName: intl.formatMessage(messages['authz.team.members.table.group.courses']),
groupIcon: School,
Expand Down
5 changes: 0 additions & 5 deletions src/authz-module/components/messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,11 +107,6 @@ const messages = defineMessages({
defaultMessage: 'Libraries',
description: 'Label for the "Libraries" group in the team members table filters',
},
'authz.team.members.table.group.global': {
id: 'authz.team.members.table.group.global',
defaultMessage: 'Global',
description: 'Label for the "Global" group in the team members table filters',
},
'authz.table.controlbar.filters.more.results': {
id: 'authz.table.controlbar.filters.more.results',
defaultMessage: 'Search to show more',
Expand Down