Skip to content

Commit 152aaa3

Browse files
arbrandesclaude
andcommitted
fix: add missing deps to registrationResult useEffect
Add USER_RETENTION_COOKIE_NAME and SESSION_COOKIE_DOMAIN to the dependency array instead of suppressing react-hooks/exhaustive-deps. Both are config constants from useAppConfig() that never change at runtime, so behavior is unchanged. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 parent 4e7f95b commit 152aaa3

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

src/register/RegistrationPage.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ const RegistrationPage = (props) => {
205205
// This is used by the "User Retention Rate Event" on GTM
206206
setCookie(USER_RETENTION_COOKIE_NAME, true, SESSION_COOKIE_DOMAIN);
207207
}
208-
}, [registrationResult]); // eslint-disable-line react-hooks/exhaustive-deps
208+
}, [registrationResult, USER_RETENTION_COOKIE_NAME, SESSION_COOKIE_DOMAIN]);
209209

210210
const handleOnChange = (event) => {
211211
const { name } = event.target;

0 commit comments

Comments
 (0)