Skip to content

Commit 42e7a68

Browse files
arbrandesclaude
andcommitted
fix: adopt frontend-base shell style manifest
The shell stylesheet moved from a SCSS file to a JS manifest at @openedx/frontend-base/shell/style. Imports it directly from site.config.dev.tsx and drops the now-redundant site.scss. Also fixes two @media queries in _base_component.scss that used a single-dash custom-media name and were silently non-matching. Refs openedx/frontend-base#232 Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 104975f commit 42e7a68

7 files changed

Lines changed: 20 additions & 30 deletions

File tree

package-lock.json

Lines changed: 7 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
"url": "git+https://github.com/openedx/frontend-app-authn.git"
1111
},
1212
"exports": {
13-
".": "./dist/index.js",
14-
"./app.scss": "./dist/app.scss"
13+
".": "./dist/index.js"
1514
},
1615
"files": [
1716
"/dist"
@@ -59,7 +58,6 @@
5958
"url": "https://github.com/openedx/frontend-app-authn/issues"
6059
},
6160
"dependencies": {
62-
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.3",
6361
"@edx/openedx-atlas": "^0.7.0",
6462
"@fortawesome/fontawesome-svg-core": "^6.7.2",
6563
"@fortawesome/free-brands-svg-icons": "^6.7.2",

site.config.dev.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { EnvironmentTypes, SiteConfig } from '@openedx/frontend-base';
22

33
import { authnApp } from './src';
44

5-
import './src/app.scss';
5+
import '@openedx/frontend-base/shell/style';
66

77
const siteConfig: SiteConfig = {
88
siteId: 'authn-dev',

src/Main.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
registerIcons,
77
} from './common-components';
88

9-
import './sass/_style.scss';
9+
import './style.scss';
1010

1111
registerIcons();
1212

src/app.scss

Lines changed: 0 additions & 2 deletions
This file was deleted.

src/sass/_base_component.scss

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
margin-bottom: 0.5rem;
6060
font-weight: 700;
6161

62-
@media (-pgn-size-breakpoint-max-width-xl) {
62+
@media (--pgn-size-breakpoint-max-width-xl) {
6363
font-size: 1.375rem;
6464
line-height: 1.75rem;
6565
}
@@ -71,7 +71,7 @@
7171
}
7272

7373
.large-screen-left-container {
74-
@media (-pgn-size-breakpoint-max-width-xl) {
74+
@media (--pgn-size-breakpoint-max-width-xl) {
7575
flex: 0 0 25%;
7676
max-width: 25%;
7777
}
Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1+
@use "@openedx/paragon/styles/css/core/custom-media-breakpoints.css";
2+
13
// Load component based styles
2-
@use "_base_component.scss";
3-
@use "_registration.scss";
4-
@use "_reset_password.scss";
5-
@use "_progressive_profiling_page.scss";
6-
@use "_login_page.scss";
7-
@use "_forgot_password.scss";
4+
@use "./sass/base_component";
5+
@use "./sass/registration";
6+
@use "./sass/reset_password";
7+
@use "./sass/progressive_profiling_page";
8+
@use "./sass/login_page";
9+
@use "./sass/forgot_password";
810

911
//
1012
// ----------------------------

0 commit comments

Comments
 (0)