Skip to content

Commit 86487a2

Browse files
arbrandesclaude
andcommitted
refactor: let composing site own shell and brand CSS
Drops the re-bundled shell stylesheet from the app so lazy-loaded app chunks no longer re-declare Paragon's :root tokens and clobber the site's brand values. Moves the dev harness's shell load into a new src/site.scss, removes the ./app.scss subpath export, and drops the @edx/brand dependency entirely since the dev harness now runs unbranded. App-scoped styles continue to load via Main.tsx. Refs openedx/frontend-base#232 Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 104975f commit 86487a2

5 files changed

Lines changed: 11 additions & 14 deletions

File tree

package-lock.json

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
"url": "git+https://github.com/openedx/frontend-app-authn.git"
1111
},
1212
"exports": {
13-
".": "./dist/index.js",
14-
"./app.scss": "./dist/app.scss"
13+
".": "./dist/index.js"
1514
},
1615
"files": [
1716
"/dist"
@@ -59,7 +58,6 @@
5958
"url": "https://github.com/openedx/frontend-app-authn/issues"
6059
},
6160
"dependencies": {
62-
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.3",
6361
"@edx/openedx-atlas": "^0.7.0",
6462
"@fortawesome/fontawesome-svg-core": "^6.7.2",
6563
"@fortawesome/free-brands-svg-icons": "^6.7.2",

site.config.dev.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { EnvironmentTypes, SiteConfig } from '@openedx/frontend-base';
22

33
import { authnApp } from './src';
44

5-
import './src/app.scss';
5+
import './site.scss';
66

77
const siteConfig: SiteConfig = {
88
siteId: 'authn-dev',

site.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
/*
2+
* Site-level stylesheet for the standalone dev harness. As the composing
3+
* site here, the dev harness is the single owner of global styles and
4+
* loads the shell stylesheet (which includes Paragon's base CSS) so that
5+
* lazy-loaded app chunks don't re-inject `:root` custom properties.
6+
*
7+
* See frontend-base docs/how_tos/theming.md for the CSS ownership rationale.
8+
*/
9+
@use "@openedx/frontend-base/shell/app.scss";

src/app.scss

Lines changed: 0 additions & 2 deletions
This file was deleted.

0 commit comments

Comments
 (0)