fix: address review nits for test mock cleanup

Remove unused useThirdPartyAuthHook mock body, inline dead
mockSetShowError variable, and extract shared TPA context mock
constant in Logistration tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: arbrandes

src/logistration/Logistration.test.jsx

@@ -46,30 +46,29 @@ jest.mock('../register/data/apiHook', () => ({
 // Mock the ThirdPartyAuthContext
 const mockClearThirdPartyAuthErrorMessage = jest.fn();
 
+const mockDefaultThirdPartyAuthContextValue = {
+  fieldDescriptions: {},
+  optionalFields: { fields: {}, extended_profile: [] },
+  thirdPartyAuthApiStatus: null,
+  thirdPartyAuthContext: {
+    autoSubmitRegForm: false,
+    currentProvider: null,
+    finishAuthUrl: null,
+    countryCode: null,
+    providers: [],
+    secondaryProviders: [],
+    pipelineUserDetails: null,
+    errorMessage: null,
+    welcomePageRedirectUrl: null,
+  },
+  setThirdPartyAuthContextBegin: jest.fn(),
+  setThirdPartyAuthContextSuccess: jest.fn(),
+  setThirdPartyAuthContextFailure: jest.fn(),
+  clearThirdPartyAuthErrorMessage: mockClearThirdPartyAuthErrorMessage,
+};
+
 jest.mock('../common-components/components/ThirdPartyAuthContext.tsx', () => ({
-  useThirdPartyAuthContext: jest.fn(() => ({
-    fieldDescriptions: {},
-    optionalFields: {
-      fields: {},
-      extended_profile: [],
-    },
-    thirdPartyAuthApiStatus: null,
-    thirdPartyAuthContext: {
-      autoSubmitRegForm: false,
-      currentProvider: null,
-      finishAuthUrl: null,
-      countryCode: null,
-      providers: [],
-      secondaryProviders: [],
-      pipelineUserDetails: null,
-      errorMessage: null,
-      welcomePageRedirectUrl: null,
-    },
-    setThirdPartyAuthContextBegin: jest.fn(),
-    setThirdPartyAuthContextSuccess: jest.fn(),
-    setThirdPartyAuthContextFailure: jest.fn(),
-    clearThirdPartyAuthErrorMessage: mockClearThirdPartyAuthErrorMessage,
-  })),
+  useThirdPartyAuthContext: jest.fn(() => mockDefaultThirdPartyAuthContextValue),
   ThirdPartyAuthProvider: ({ children }) => children,
 }));
 
@@ -185,29 +184,16 @@ describe('Logistration', () => {
     // Update the mock to include secondary providers
     const { useThirdPartyAuthContext } = require('../common-components/components/ThirdPartyAuthContext.tsx');
     useThirdPartyAuthContext.mockReturnValue({
-      fieldDescriptions: {},
-      optionalFields: { fields: {}, extended_profile: [] },
-      thirdPartyAuthApiStatus: null,
+      ...mockDefaultThirdPartyAuthContextValue,
       thirdPartyAuthContext: {
-        autoSubmitRegForm: false,
-        currentProvider: null,
-        finishAuthUrl: null,
-        countryCode: null,
-        providers: [],
+        ...mockDefaultThirdPartyAuthContextValue.thirdPartyAuthContext,
         secondaryProviders: [{
           id: 'saml-test',
           name: 'Test University',
           loginUrl: '/dummy-auth',
           registerUrl: '/dummy_auth',
         }],
-        pipelineUserDetails: null,
-        errorMessage: null,
-        welcomePageRedirectUrl: null,
       },
-      setThirdPartyAuthContextBegin: jest.fn(),
-      setThirdPartyAuthContextSuccess: jest.fn(),
-      setThirdPartyAuthContextFailure: jest.fn(),
-      clearThirdPartyAuthErrorMessage: mockClearThirdPartyAuthErrorMessage,
     });
 
     const props = { selectedPage: LOGIN_PAGE };
@@ -230,29 +216,16 @@ describe('Logistration', () => {
 
     const { useThirdPartyAuthContext } = require('../common-components/components/ThirdPartyAuthContext.tsx');
     useThirdPartyAuthContext.mockReturnValue({
-      fieldDescriptions: {},
-      optionalFields: { fields: {}, extended_profile: [] },
-      thirdPartyAuthApiStatus: null,
+      ...mockDefaultThirdPartyAuthContextValue,
       thirdPartyAuthContext: {
-        autoSubmitRegForm: false,
-        currentProvider: null,
-        finishAuthUrl: null,
-        countryCode: null,
-        providers: [],
+        ...mockDefaultThirdPartyAuthContextValue.thirdPartyAuthContext,
         secondaryProviders: [{
           id: 'saml-test',
           name: 'Test University',
           loginUrl: '/dummy-auth',
           registerUrl: '/dummy_auth',
         }],
-        pipelineUserDetails: null,
-        errorMessage: null,
-        welcomePageRedirectUrl: null,
       },
-      setThirdPartyAuthContextBegin: jest.fn(),
-      setThirdPartyAuthContextSuccess: jest.fn(),
-      setThirdPartyAuthContextFailure: jest.fn(),
-      clearThirdPartyAuthErrorMessage: mockClearThirdPartyAuthErrorMessage,
     });
 
     const props = { selectedPage: LOGIN_PAGE };
@@ -274,29 +247,16 @@ describe('Logistration', () => {
 
     const { useThirdPartyAuthContext } = require('../common-components/components/ThirdPartyAuthContext.tsx');
     useThirdPartyAuthContext.mockReturnValue({
-      fieldDescriptions: {},
-      optionalFields: { fields: {}, extended_profile: [] },
-      thirdPartyAuthApiStatus: null,
+      ...mockDefaultThirdPartyAuthContextValue,
       thirdPartyAuthContext: {
-        autoSubmitRegForm: false,
-        currentProvider: null,
-        finishAuthUrl: null,
-        countryCode: null,
-        providers: [],
+        ...mockDefaultThirdPartyAuthContextValue.thirdPartyAuthContext,
         secondaryProviders: [{
           id: 'saml-test',
           name: 'Test University',
           loginUrl: '/dummy-auth',
           registerUrl: '/dummy_auth',
         }],
-        pipelineUserDetails: null,
-        errorMessage: null,
-        welcomePageRedirectUrl: null,
       },
-      setThirdPartyAuthContextBegin: jest.fn(),
-      setThirdPartyAuthContextSuccess: jest.fn(),
-      setThirdPartyAuthContextFailure: jest.fn(),
-      clearThirdPartyAuthErrorMessage: mockClearThirdPartyAuthErrorMessage,
     });
 
     delete window.location;

src/progressive-profiling/data/apiHook.test.ts

@@ -36,7 +36,6 @@ const createWrapper = () => {
 };
 
 describe('useSaveUserProfile', () => {
-  const mockSetShowError = jest.fn();
   const mockSetSuccess = jest.fn();
   const mockSetSubmitState = jest.fn();
 
@@ -45,7 +44,7 @@ describe('useSaveUserProfile', () => {
     showError: false,
     success: false,
     setLoading: jest.fn(),
-    setShowError: mockSetShowError,
+    setShowError: jest.fn(),
     setSuccess: mockSetSuccess,
     setSubmitState: mockSetSubmitState,
     clearState: jest.fn(),

src/register/components/tests/ConfigurableRegistrationForm.test.jsx

@@ -39,12 +39,7 @@ jest.mock('../../../common-components/components/ThirdPartyAuthContext', () => (
 }));
 
 jest.mock('../../../common-components/data/apiHook', () => ({
-  useThirdPartyAuthHook: jest.fn().mockReturnValue({
-    data: null,
-    isSuccess: false,
-    error: null,
-    isLoading: false,
-  }),
+  useThirdPartyAuthHook: jest.fn(() => ({})),
 }));
 
 jest.mock('react-router-dom', () => {

src/register/components/tests/RegistrationFailure.test.jsx

@@ -41,12 +41,7 @@ jest.mock('../../../common-components/components/ThirdPartyAuthContext', () => (
 }));
 
 jest.mock('../../../common-components/data/apiHook', () => ({
-  useThirdPartyAuthHook: jest.fn().mockReturnValue({
-    data: null,
-    isSuccess: false,
-    error: null,
-    isLoading: false,
-  }),
+  useThirdPartyAuthHook: jest.fn(() => ({})),
 }));
 
 jest.mock('react-router-dom', () => {