feat: frontend-base i18n support#1661
Merged
arbrandes merged 4 commits intoApr 9, 2026
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1661 +/- ##
==============================================
Coverage 92.12% 92.12%
==============================================
Files 92 92
Lines 2045 2045
Branches 577 588 +11
==============================================
Hits 1884 1884
Misses 158 158
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frontend-base i18n support
- Rename src/i18n/index.js → index.ts (project uses TypeScript) - Add src/i18n/messages.d.ts type stub so TypeScript is satisfied before translations:pull has been run - Remove src/i18n/messages.ts from git tracking (gitignored, generated) - Remove unused intl_imports and i18n Makefile variables - Remove detect_changed_source_translations Makefile target (unused by any CI workflow, extract_translations, or pull_translations) - Update package-lock to resolve @openedx/frontend-base to 1.0.0-alpha.23 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
arbrandes
approved these changes
Apr 9, 2026
|
🎉 This PR is included in version 1.0.0-alpha.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three changes to wire up
frontend-basei18n support in this app, per the migration guide:1. Add
atlasTranslationstopackage.jsonAdds an
atlasTranslationsfield so that sites usingopenedx translations:pullcan resolve and pull this app's translations transitively, and so the app can pull its own translations when running in dev mode.2. Switch
pull_translationsto useopenedx translations:pullReplaces the old Makefile atlas pull commands with
npm run translations:pull(backed byopenedx translations:pull), passingATLAS_OPTIONSthrough. Also removes the placeholdermessagesobject fromsrc/i18n/index.jsand the manualmessagesimport insrc/app.ts— translations are now handled by the frontend-base i18n pipeline.Also removes the unused
intl_importsandi18nMakefile variables and thedetect_changed_source_translationstarget (confirmed unused by any CI workflow or translation-related target).3. Add
src/i18n/index.tsandsrc/i18n/messages.d.tsRenames
src/i18n/index.js→index.ts(the project uses TypeScript) and adds amessages.d.tstype declaration stub so TypeScript is satisfied beforetranslations:pullhas been run.Before merging
feat: add(landed as 1.0.0-alpha.23)translations:CLI commands and update runtime i18n integration frontend-base#205 must land firstnpm run dev(the app's own dev site) can pull and load translations correctlyfrontend-basefrom the feat: addtranslations:CLI commands and update runtime i18n integration frontend-base#205 branchfrontend-baseafter feat: addtranslations:CLI commands and update runtime i18n integration frontend-base#205 lands🤖 Generated with Claude Code