chore: add build:ci smoke test to verify webpack build#1668
Merged
Conversation
arbrandes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #1668 +/- ##
================================================
Coverage ? 92.08%
================================================
Files ? 93
Lines ? 2046
Branches ? 588
================================================
Hits ? 1884
Misses ? 159
Partials ? 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds a build-ci make target (exposed as npm run build:ci) that runs openedx build against site.config.dev.tsx, and wires it into the CI workflow after the existing tsc-based build step. Catches errors in the real app graph (e.g. broken imports in lazy-loaded routes) that neither tsc nor Jest would surface. Co-Authored-By: Claude <noreply@anthropic.com>
Comment on lines
+16
to
+21
| apps: [ | ||
| shellApp, | ||
| headerApp, | ||
| footerApp, | ||
| authnApp, | ||
| ], |
Contributor
There was a problem hiding this comment.
I assume the goal here is to verify the chromeless stuff from openedx/frontend-base#220 works?
Is that something we need in the dev config?
Contributor
Author
There was a problem hiding this comment.
It's not something we need, but something we want: we should catch during development whether chromeless is failing, for whatever reason.
brian-smith-tcril
approved these changes
Apr 23, 2026
|
🎉 This PR is included in version 1.0.0-alpha.13 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apps are distributed build-less, so
npm run buildonly compiles the librarydist/viatscand nothing in CI verifies that the app can actually be webpack-bundled as a deployable site. This PR adds annpm run build:ciscript that exercises the real app graph through webpack, and wires it into the CI workflow after the existing build step.Refs openedx/frontend-base#124.
Verifying the check
Introduce a typo in an import in
src/routes.jsx(for example, changefrom './forgot-password'tofrom './forgot-password-typo').npm run buildstill passes, butnpm run build:cifails with a module resolution error. Revert the typo and the build goes green again.LLM usage notice
Built with assistance from Claude.