Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ jobs:
- name: Build
run: npm run build

- name: Build (CI)
run: npm run build:ci

- name: Run Code Coverage
uses: codecov/codecov-action@v5
with:
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@ build:
cp "$$f" "$$d"; \
done' sh {} +

build-ci:
SITE_CONFIG_PATH=site.config.ci.tsx openedx build

extract_translations: | requirements
# Pulling display strings from source files into src/i18n/transifex_input.json...
npm run i18n_extract
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
},
"scripts": {
"build": "make build",
"build:ci": "make build-ci",
"build:packages": "make build-packages",
"clean": "make clean",
"clean:packages": "make clean-packages",
Expand Down
24 changes: 24 additions & 0 deletions site.config.ci.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { EnvironmentTypes, SiteConfig, footerApp, headerApp, shellApp } from '@openedx/frontend-base';

import { authnApp } from './src';

import '@openedx/frontend-base/shell/style';

const siteConfig: SiteConfig = {
siteId: 'authn-ci',
siteName: 'Authn CI',
baseUrl: 'http://apps.local.openedx.io',
lmsBaseUrl: 'http://local.openedx.io',
loginUrl: 'http://local.openedx.io/login',
logoutUrl: 'http://local.openedx.io/logout',

environment: EnvironmentTypes.PRODUCTION,
apps: [
shellApp,
headerApp,
footerApp,
authnApp,
],
};

export default siteConfig;
9 changes: 7 additions & 2 deletions site.config.dev.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { EnvironmentTypes, SiteConfig } from '@openedx/frontend-base';
import { EnvironmentTypes, SiteConfig, footerApp, headerApp, shellApp } from '@openedx/frontend-base';

import { authnApp } from './src';

Expand All @@ -13,7 +13,12 @@ const siteConfig: SiteConfig = {
logoutUrl: 'http://local.openedx.io:8000/logout',

environment: EnvironmentTypes.DEVELOPMENT,
apps: [authnApp],
apps: [
shellApp,
headerApp,
footerApp,
authnApp,
],
Comment on lines +16 to +21
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the goal here is to verify the chromeless stuff from openedx/frontend-base#220 works?

Is that something we need in the dev config?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not something we need, but something we want: we should catch during development whether chromeless is failing, for whatever reason.

};

export default siteConfig;
Loading