refactor: remove legacy waffle flags consumption 1.b.ii

Author: farhan

src/course-unit/add-component/AddComponent.test.tsx

@@ -2,7 +2,6 @@
 /* eslint-disable react/prop-types */
 import userEvent, { UserEvent } from '@testing-library/user-event';
 
-import { mockWaffleFlags } from '@src/data/apiHooks.mock';
 import { RenderResult } from '@testing-library/react';
 import {
   act,
@@ -360,19 +359,6 @@ describe('<AddComponent />', () => {
     }, expect.any(Function));
   });
 
-  it('adds a PDF block and launches the legacy iframe editor', async () => {
-    const user = userEvent.setup();
-    mockWaffleFlags({ useNewPdfEditor: false });
-    const { getByRole, queryAllByRole } = renderComponent();
-    await createPdfBlock({ getByRole, queryAllByRole, user });
-    expect(handleCreateNewCourseXBlockMock).toHaveBeenCalled();
-    expect(handleCreateNewCourseXBlockMock).toHaveBeenCalledWith({
-      parentLocator: '123',
-      type: COMPONENT_TYPES.pdf,
-      // Setting the category and not supplying an additional function launches the traditional editor.
-      category: COMPONENT_TYPES.pdf,
-    });
-  });
 
   it('verifies "Text" component selection in modal', async () => {
     const user = userEvent.setup();

src/course-unit/add-component/AddComponent.tsx

@@ -86,7 +86,7 @@ const AddComponent = ({
   const [selectedComponents, setSelectedComponents] = useState<SelectedComponent[]>([]);
   const [usageId, setUsageId] = useState(null);
   const { sendMessageToIframe } = useIframe();
-  const { useVideoGalleryFlow, useNewPdfEditor } = useWaffleFlags(courseId ?? undefined);
+  const { useVideoGalleryFlow } = useWaffleFlags(courseId ?? undefined);
 
   const courseUnit = useSelector(getCourseUnitData);
   const sequenceId = courseUnit?.ancestorInfo?.ancestors?.[0]?.id;
@@ -181,13 +181,13 @@ const AddComponent = ({
         // *in code* and not just in UI seems like a mistake in retrospect.
         //
         // There will be more of these, and soon.
-        if (moduleName === COMPONENT_TYPES.pdf && useNewPdfEditor) {
+        if (moduleName === COMPONENT_TYPES.pdf) {
           handleCreateNewCourseXBlock(
             { type: moduleName, parentLocator: blockId },
             /* istanbul ignore next */
             ({ courseKey, locator }) => {
               setCourseId(courseKey);
-              setBlockType(moduleName);
+              setBlockType(moduleName ?? null);
               setNewBlockId(locator);
               showXBlockEditorModal();
             },

src/course-unit/breadcrumbs/Breadcrumbs.test.tsx

@@ -151,23 +151,4 @@ describe('<Breadcrumbs />', () => {
     expect(dropdownItem).toHaveAttribute('href', url);
   });
 
-  it('falls back to window.location.href when the waffle flag is disabled', async () => {
-    const user = userEvent.setup();
-    // eslint-disable-next-line @typescript-eslint/naming-convention
-    const { ancestor_xblocks: [{ children: [{ display_name, url }] }] } = courseSectionVerticalMock;
-    axiosMock
-      .onGet(getApiWaffleFlagsUrl(courseId))
-      .reply(200, { useNewCourseOutlinePage: false });
-
-    const { getByText, getByRole } = renderComponent();
-
-    const dropdownBtn = getByText(breadcrumbsExpected.section.displayName);
-    await user.click(dropdownBtn);
-
-    const dropdownItem = getByRole('link', { name: display_name });
-    // We need waitFor here because the waffle flag defaults to true but asynchronously loads false from our axiosMock
-    await waitFor(() => {
-      expect(dropdownItem).toHaveAttribute('href', `${getConfig().STUDIO_BASE_URL}${url}`);
-    });
-  });
 });

src/course-unit/breadcrumbs/Breadcrumbs.tsx

@@ -5,31 +5,21 @@ import {
   ArrowDropDown as ArrowDropDownIcon,
   ChevronRight as ChevronRightIcon,
 } from '@openedx/paragon/icons';
-import { getConfig } from '@edx/frontend-platform';
-
-import { useWaffleFlags } from '../../data/apiHooks';
 import { getCourseSectionVertical } from '../data/selectors';
 import { adoptCourseSectionUrl, subsectionFirstUnitEditUrl } from '../utils';
 
 const Breadcrumbs = ({ courseId, parentUnitId }: { courseId: string; parentUnitId: string; }) => {
   const { ancestorXblocks = [] } = useSelector(getCourseSectionVertical);
-  const waffleFlags = useWaffleFlags(courseId);
-
-  const getPathToCourseOutlinePage = (url) => (waffleFlags.useNewCourseOutlinePage
-    ? url :
-    `${getConfig().STUDIO_BASE_URL}${url}`);
 
-  const getPathToCourseUnitPage = (url) => (waffleFlags.useNewUnitPage
-    ? adoptCourseSectionUrl({ url, courseId, parentUnitId })
-    : `${getConfig().STUDIO_BASE_URL}${url}`);
+  const getPathToCourseUnitPage = (url) => adoptCourseSectionUrl({ url, courseId, parentUnitId });
 
   // based on the level of breadcrumbs the url will differ
   // at the subsection level it should navigate to the first unit if available
   // if no unit then navigate to the subsection outline
   function getPathToCoursePage(index, url, usageKey: string) {
     let navUrl: string;
     if (index === 0) {
-      navUrl = getPathToCourseOutlinePage(url);
+      navUrl = url;
     } else if (index === 1) {
       navUrl = subsectionFirstUnitEditUrl({ courseId, subsectionId: usageKey });
     } else {