refactor: Remove Legacy UI Waffle Flag Consumers — Phase 1c (#5)

* refactor: Remove Legacy UI Waffle Flag Consumers — Phase 1c

* refactor: remove useNewUpdatesPage and useNewCustomPages waffle flags

Remove routing waffle flags from useContentMenuItems (useNewUpdatesPage),
useSettingMenuItems (unused waffleFlags ref), and PageSettingButton tests
(useNewCustomPages legacy-link test). All paths now always resolve to MFE.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: farhan

src/CourseAuthoringContext.tsx

@@ -1,4 +1,3 @@
-import { getConfig } from '@edx/frontend-platform';
 import {
   createContext,
   useContext,
@@ -10,7 +9,7 @@ import { useNavigate } from 'react-router';
 import { useToggleWithValue } from '@src/hooks';
 import { type UnitXBlock, type XBlock } from '@src/data/types';
 import { CourseDetailsData } from './data/api';
-import { useCourseDetails, useWaffleFlags } from './data/apiHooks';
+import { useCourseDetails } from './data/apiHooks';
 import { RequestStatusType } from './data/constants';
 import { getOutlineIndexData } from './course-outline/data/selectors';
 
@@ -53,7 +52,6 @@ export const CourseAuthoringProvider = ({
   courseId,
 }: CourseAuthoringProviderProps) => {
   const navigate = useNavigate();
-  const waffleFlags = useWaffleFlags();
   const { data: courseDetails, status: courseDetailStatus } = useCourseDetails(courseId);
   const canChangeProviders = getAuthenticatedUser().administrator || new Date(courseDetails?.start ?? 0) > new Date();
   const { courseStructure } = useSelector(getOutlineIndexData);
@@ -65,26 +63,12 @@ export const CourseAuthoringProvider = ({
     closeUnlinkModal,
   ] = useToggleWithValue<ModalState>();
 
-  const getUnitUrl = (locator: string) => {
-    if (getConfig().ENABLE_UNIT_PAGE === 'true' && waffleFlags.useNewUnitPage) {
-      // instanbul ignore next
-      return `/course/${courseId}/container/${locator}`;
-    }
-    return `${getConfig().STUDIO_BASE_URL}/container/${locator}`;
-  };
+  const getUnitUrl = (locator: string) => `/course/${courseId}/container/${locator}`;
 
   /**
    * Open the unit page for a given locator.
    */
-  const openUnitPage = async (locator: string) => {
-    const url = getUnitUrl(locator);
-    if (getConfig().ENABLE_UNIT_PAGE === 'true' && waffleFlags.useNewUnitPage) {
-      // instanbul ignore next
-      navigate(url);
-    } else {
-      window.location.assign(url);
-    }
-  };
+  const openUnitPage = async (locator: string) => { navigate(getUnitUrl(locator)); };
 
   const context = useMemo<CourseAuthoringContextData>(() => ({
     courseId,

src/editors/containers/VideoEditor/components/VideoEditorModal.tsx

@@ -1,7 +1,6 @@
 import React, { useEffect } from 'react';
 import { useDispatch, useSelector } from 'react-redux';
 import { useLocation } from 'react-router-dom';
-import { useWaffleFlags } from '@src/data/apiHooks';
 import * as appHooks from '../../../hooks';
 import { thunkActions, selectors } from '../../../data/redux';
 import VideoSettingsModal from './VideoSettingsModal';
@@ -42,7 +41,6 @@ const VideoEditorModal: React.FC<Props> = ({
   const isLoaded = useSelector(
     (state) => selectors.requests.isFinished(state, { requestKey: RequestKeys.fetchVideos }),
   );
-  const { useNewVideoUploadsPage } = useWaffleFlags();
 
   useEffect(() => {
     hooks.initialize(dispatch, selectedVideoId, selectedVideoUrl);
@@ -54,7 +52,6 @@ const VideoEditorModal: React.FC<Props> = ({
         onReturn: onSettingsReturn,
         isLibrary,
         onClose,
-        useNewVideoUploadsPage,
       }}
     />
   );

src/editors/containers/VideoEditor/components/VideoSettingsModal/index.test.tsx

@@ -10,7 +10,6 @@ const defaultProps = {
   onReturn: jest.fn(),
   isLibrary: false,
   onClose: jest.fn(),
-  useNewVideoUploadsPage: true,
 };
 
 const renderComponent = (overrideProps = {}) => {
@@ -38,7 +37,7 @@ describe('<VideoSettingsModal />', () => {
     window.scrollTo = jest.fn();
   });
 
-  it('renders back button when useNewVideoUploadsPage is true and isLibrary is false', () => {
+  it('renders back button when isLibrary is false', () => {
     renderComponent();
     expect(screen.getByRole('button', { name: /replace video/i })).toBeInTheDocument();
   });

src/editors/containers/VideoEditor/components/VideoSettingsModal/index.tsx

@@ -21,17 +21,15 @@ interface Props {
   onReturn: () => void;
   isLibrary: boolean;
   onClose?: (() => void) | null;
-  useNewVideoUploadsPage?: boolean;
 }
 
 const VideoSettingsModal: React.FC<Props> = ({
   onReturn,
   isLibrary,
   onClose,
-  useNewVideoUploadsPage,
 }) => (
   <>
-    {!isLibrary && useNewVideoUploadsPage && (
+    {!isLibrary && (
       <Button
         variant="link"
         className="text-primary-500"

src/header/hooks.test.tsx

@@ -22,12 +22,7 @@ jest.mock('@edx/frontend-platform/i18n', () => ({
 }));
 
 // Bypass React Query for waffle flags, and just return the default values.
-mockWaffleFlags({
-  // Some flags can be enabled with either a config value or a waffle flag.
-  // For test purposes, we'll configure the video upload page using the config, so leave the waffle flag off.
-  useNewVideoUploadsPage: false,
-  useNewCertificatesPage: false,
-});
+mockWaffleFlags({});
 
 jest.mock('react-redux', () => ({
   ...jest.requireActual('react-redux'),

src/header/hooks.tsx

@@ -22,8 +22,6 @@ import { getCourseUpdatesPermissions } from '@src/authz/permissionHelpers';
 
 export const useContentMenuItems = (courseId: string) => {
   const intl = useIntl();
-  const studioBaseUrl = getConfig().STUDIO_BASE_URL;
-  const waffleFlags = useWaffleFlags(courseId);
   const { librariesV2Enabled } = useSelector(getStudioHomeData);
 
   const { canViewCourseUpdates, canViewPagesAndResources } = useCourseUserPermissions(
@@ -36,14 +34,12 @@ export const useContentMenuItems = (courseId: string) => {
 
   const items = [
     {
-      href: waffleFlags.useNewCourseOutlinePage ? `/course/${courseId}` : `${studioBaseUrl}/course/${courseId}`,
+      href: `/course/${courseId}`,
       title: intl.formatMessage(messages['header.links.outline']),
     },
     ...(canViewCourseUpdates ?
       [{
-        href: waffleFlags.useNewUpdatesPage
-          ? `/course/${courseId}/course_info`
-          : `${studioBaseUrl}/course_info/${courseId}`,
+        href: `/course/${courseId}/course_info`,
         title: intl.formatMessage(messages['header.links.updates']),
       }] :
       []),
@@ -54,11 +50,12 @@ export const useContentMenuItems = (courseId: string) => {
       }]
       : []),
     {
-      href: waffleFlags.useNewFilesUploadsPage ? `/course/${courseId}/assets` : `${studioBaseUrl}/assets/${courseId}`,
+      href: `/course/${courseId}/assets`,
       title: intl.formatMessage(messages['header.links.filesAndUploads']),
     },
   ];
-  if (getConfig().ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN === 'true' || waffleFlags.useNewVideoUploadsPage) {
+
+  if (getConfig().ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN === 'true') {
     items.push({
       href: `/course/${courseId}/videos`,
       title: intl.formatMessage(messages['header.links.videoUploads']),
@@ -78,7 +75,6 @@ export const useContentMenuItems = (courseId: string) => {
 export const useSettingMenuItems = (courseId: string) => {
   const intl = useIntl();
   const { canAccessAdvancedSettings: legacyCanAccessAdvancedSettings } = useSelector(getStudioHomeData);
-  const waffleFlags = useWaffleFlags(courseId);
 
   /*
     AuthZ for Course Authoring
@@ -133,7 +129,7 @@ export const useSettingMenuItems = (courseId: string) => {
       }] :
       []),
   ];
-  if (getConfig().ENABLE_CERTIFICATE_PAGE === 'true' || waffleFlags.useNewCertificatesPage) {
+  if (getConfig().ENABLE_CERTIFICATE_PAGE === 'true') {
     items.push({
       href: `/course/${courseId}/certificates`,
       title: intl.formatMessage(messages['header.links.certificates']),
@@ -144,21 +140,20 @@ export const useSettingMenuItems = (courseId: string) => {
 
 export const useToolsMenuItems = (courseId: string) => {
   const intl = useIntl();
-  const studioBaseUrl = getConfig().STUDIO_BASE_URL;
   const waffleFlags = useWaffleFlags();
 
   const items = [
     {
-      href: waffleFlags.useNewImportPage ? `/course/${courseId}/import` : `${studioBaseUrl}/import/${courseId}`,
+      href: `/course/${courseId}/import`,
       title: intl.formatMessage(messages['header.links.import']),
     },
     {
-      href: waffleFlags.useNewExportPage ? `/course/${courseId}/export` : `${studioBaseUrl}/export/${courseId}`,
+      href: `/course/${courseId}/export`,
       title: intl.formatMessage(messages['header.links.exportCourse']),
     },
     ...(getConfig().ENABLE_TAGGING_TAXONOMY_PAGES === 'true'
       ? [{
-        href: `${studioBaseUrl}/course/${courseId}#export-tags`,
+        href: `${getConfig().STUDIO_BASE_URL}/course/${courseId}#export-tags`,
         title: intl.formatMessage(messages['header.links.exportTags']),
       }] :
       []),

src/pages-and-resources/pages/PageSettingButton.jsx

@@ -6,7 +6,6 @@ import { Icon, IconButton } from '@openedx/paragon';
 import { ArrowForward, Settings } from '@openedx/paragon/icons';
 import { useNavigate, Link } from 'react-router-dom';
 
-import { useWaffleFlags } from '../../data/apiHooks';
 import { useCourseUserPermissions } from '../../authz/hooks';
 import { getAdvancedSettingsPermissions } from '../../authz/permissionHelpers';
 import messages from '../messages';
@@ -22,25 +21,12 @@ const PageSettingButton = ({
   const { path: pagesAndResourcesPath, isEditable } = useContext(PagesAndResourcesContext);
   const { canManageAdvancedSettings } = useCourseUserPermissions(courseId, getAdvancedSettingsPermissions(courseId));
   const navigate = useNavigate();
-  const waffleFlags = useWaffleFlags(courseId);
 
-  const determineLinkDestination = useMemo(() => {
-    if (!legacyLink) { return null; }
-
-    if (legacyLink.includes('textbooks')) {
-      return waffleFlags.useNewTextbooksPage
-        ? `/course/${courseId}/${id.replace('_', '-')}`
-        : legacyLink;
-    }
-
-    if (legacyLink.includes('tabs')) {
-      return waffleFlags.useNewCustomPages
-        ? `/course/${courseId}/${id.replace('_', '-')}`
-        : legacyLink;
-    }
-
-    return null;
-  }, [legacyLink, waffleFlags, id]);
+  const determineLinkDestination = useMemo(() => (
+    legacyLink?.includes('textbooks') || legacyLink?.includes('tabs')
+      ? `/course/${courseId}/${id.replace('_', '-')}`
+      : null
+  ), [legacyLink, courseId, id]);
 
   const canConfigureOrEnable = allowedOperations?.configure || allowedOperations?.enable;
 

src/pages-and-resources/pages/PageSettingButton.test.jsx

@@ -1,7 +1,6 @@
 // @ts-check
 import { screen, render, initializeMocks, fireEvent } from '../../testUtils';
 import PageSettingButton from './PageSettingButton';
-import { mockWaffleFlags } from '../../data/apiHooks.mock';
 import { useCourseUserPermissions } from '../../authz/hooks';
 import PagesAndResourcesProvider from '../PagesAndResourcesProvider';
 
@@ -30,14 +29,12 @@ const renderComponent = (props = {}, { isEditable = true, canManageAdvancedSetti
   );
 };
 
-mockWaffleFlags();
-
 describe('PageSettingButton', () => {
   beforeEach(() => {
     initializeMocks();
   });
 
-  it('renders the settings button with the new textbooks page link when useNewTextbooksPage is true', () => {
+  it('renders the settings button with the new textbooks page link', () => {
     renderComponent({ legacyLink: 'http://legacylink.com/textbooks' });
 
     const linkElement = screen.getByRole('link');
@@ -50,31 +47,13 @@ describe('PageSettingButton', () => {
     expect(screen.queryByRole('link')).toBeNull();
   });
 
-  it('renders the settings button with the legacy link when useNewTextbooksPage is false', () => {
-    mockWaffleFlags({ useNewTextbooksPage: false });
-
-    renderComponent({ legacyLink: 'http://legacylink.com/textbooks' });
-
-    const linkElement = screen.getByRole('link');
-    expect(linkElement).toHaveAttribute('href', 'http://legacylink.com/textbooks');
-  });
-
-  it('renders the settings button with the new custom pages link when useNewCustomPages is true', () => {
+  it('renders the settings button with the new custom pages link', () => {
     renderComponent();
 
     const linkElement = screen.getByRole('link');
     expect(linkElement).toHaveAttribute('href', `/course/${defaultProps.courseId}/page-id`);
   });
 
-  it('renders the settings button with the legacy link when useNewCustomPages is false', () => {
-    mockWaffleFlags({ useNewCustomPages: false });
-
-    renderComponent();
-
-    const linkElement = screen.getByRole('link');
-    expect(linkElement).toHaveAttribute('href', defaultProps.legacyLink);
-  });
-
   it('renders disabled icon button in read-only mode with legacy link', () => {
     renderComponent({ legacyLink: 'http://legacylink.com/textbooks' }, { isEditable: false });