Multiple API endpoints for courseDetails

[ChrisChV]

There are multiple endpoints for the "same" course details functionality:

• https://github.com/openedx/frontend-app-authoring/blob/master/src/course-outline/data/api.ts#L22
• https://github.com/openedx/frontend-app-authoring/blob/master/src/data/api.ts#L5
• https://github.com/openedx/frontend-app-authoring/blob/master/src/schedule-and-details/data/api.ts#L6

Check if it's possible to use only one endpoint and place it generically so that it can be used in all those locations

[bradenmacdonald]

1 and 3 seem like the same API, but isn't the second one a different API? I guess they all play a similar role though.

[prnvjn]

Hi @bradenmacdonald and @ChrisChV ,

I'd like to contribute a fix

I was thinking to extract a single shared getCourseDetails/updateCourseDetails into one module and have both features import it.

Quick question before I start
is there a preferred location for shared cross-feature API code or an existing convention I should follow?

[bradenmacdonald]

Thanks @prnvjn, that would be great!

I do want to flag that @taimoor-ahmed-1 is currently working on the course details API[s] as well, but more changing the endpoint than changing much on the Authoring side, so I don't think there's going to be much overlap/conflict. #3136 (@taimoor-ahmed-1 please correct me if I'm wrong and you think @prnvjn should hold off for now).

is there a preferred location for shared cross-feature API code or an existing convention I should follow?

We haven't been very consistent with that sort of thing yet in this repo, so pick what seems to make the most sense to you for now and we can always adjust it in code review, but anything reasonable should be good.