fix: "Back up" is two words when used as a verb#2696
Merged
Conversation
bradenmacdonald
approved these changes
Nov 25, 2025
Contributor
|
Looks like you'll need to update the corresponding test too, before this can merge. |
4b51f51 to
bb0a65b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2696 +/- ##
=======================================
Coverage 94.85% 94.85%
=======================================
Files 1232 1232
Lines 27870 27899 +29
Branches 6129 6136 +7
=======================================
+ Hits 26436 26464 +28
- Misses 1376 1377 +1
Partials 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is a new menu item "Backup to local archive". Backup is the correct spelling when using it as a noun or adjective, but the menu item uses as a verb, so it should be two words, back up, i.e. "Back up to local archive"
Note: alternatively, if we want to stick with the spelling "backup", the menu item could be rephrased. For example, "Create local backup" or "Local backup archive" use the noun and adjective forms, respectively.
If accepted I'll backport (back port?) this to Ulmo.
Before
After
Supporting information
https://www.merriam-webster.com/dictionary/backup#dictionary-entry-2
Best Practices Checklist
N/A