Skip to content

fix: restore republish on unit visibility change from outline configure modal #3026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradenmacdonald merged 2 commits into from
May 1, 2026
Merged

fix: restore republish on unit visibility change from outline configure modal #3026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5c256d
fix: restore republish on unit visibility change from outline configu…
Anas12091101 Apr 24, 2026
7466b67
fix: test
Anas12091101 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/course-outline/data/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ export async function configureCourseSubsection(
*/
export async function configureCourseUnit(variables: ConfigureUnitData): Promise<object> {
const body = {
publish: variables.groupAccess ? null : variables.type,

@Anas12091101 Anas12091101 Apr 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera, I am not sure if this was an intentional change in 806135e#diff-d8acab706381e84f07184d02fabb56bdd3c592155995f442f50fdd56493fba52R313. Could you please confirm?

@navinkarkera navinkarkera Apr 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anas12091101 Actually, I updated this to match and remove duplicate configure course unit visibility api function: here

This means that before it was not consistent, changing visibility from unit page required a publish while changing visibility from outline did not.

@Anas12091101 Anas12091101 Apr 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navinkarkera, has there been a decision to require publishing from the outline page? If so, could you point me to the relevant discussion or reference?

Also, the check variables.groupAccess ? null : variables.type will evaluate to null even when groupAccess is an empty object ({}). Is that intentional?

@navinkarkera navinkarkera Apr 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

has there been a decision to require publishing from the outline page? If so, could you point me to the relevant discussion or reference?

@Anas12091101 Nope, I just shared why this change came into picture. I don't mind it in either way (auto publish or not), so no objections to this PR.

Also, the check variables.groupAccess ? null : variables.type will evaluate to null even when groupAccess is an empty object ({}). Is that intentional?

No, like I said, it was copied/moved over from duplicate function from unit page.

publish: variables.type,
...(variables.type === PUBLISH_TYPES.republish ?
{
metadata: {
Expand Down
2 changes: 1 addition & 1 deletion src/course-unit/CourseUnit.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,7 +1465,7 @@ describe('<CourseUnit />', () => {

axiosMock
.onPost(getXBlockBaseApiUrl(courseSectionVerticalMock.xblock_info.id), {
publish: null,
publish: 'republish',
metadata: { visible_to_staff_only: true, group_access: { 50: [2] }, discussion_enabled: true },
})
.reply(200, { dummy: 'value' });
Expand Down