Skip to content

fix: gate studio home roles and permissions button on authz waffle flag#3072

Open
Anas12091101 wants to merge 1 commit into
openedx:masterfrom
mitodl:anas/fix-studio-home-roles-button-authz-flag
Open

fix: gate studio home roles and permissions button on authz waffle flag#3072
Anas12091101 wants to merge 1 commit into
openedx:masterfrom
mitodl:anas/fix-studio-home-roles-button-authz-flag

Conversation

@Anas12091101
Copy link
Copy Markdown
Contributor

Description

The "Roles and permissions" button on the Studio Home page was unconditionally rendered for all active users, regardless of whether the authz.enable_course_authoring waffle flag was enabled.
The button is now gated on both enableAuthzCourseAuthoring waffle flag and ADMIN_CONSOLE_URL being configured, consistent with how the course-level settings menu already behaves. Tests have been updated to cover both the enabled and disabled states.

Useful information to include:

  • Which user roles will this change impact? Course Author
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).

Before
Screenshot 2026-06-02 at 1 17 10 PM

After
Screenshot 2026-06-02 at 1 16 07 PM

Supporting information

https://github.com/mitodl/hq/issues/11519

Testing instructions

  • Enable the authz.enable_course_authoring waffle flag in Django Admin → Waffle → Flags and ensure ADMIN_CONSOLE_URL is set in the MFE config. Navigate to Studio Home and verify that the "Roles and permissions" button appears in the header.

  • Disable the flag (or leave it unset) and verify the "Roles and permissions" button is not present on Studio Home.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Avoid propTypes and defaultProps in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Do not add new fields to the Redux state/store. Use React Context to share state among multiple components.
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Avoid using ../ in import paths. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jun 2, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @Anas12091101!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.60%. Comparing base (1d83fef) to head (59c3183).

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #3072    +/-   ##
========================================
  Coverage   95.60%   95.60%            
========================================
  Files        1391     1391            
  Lines       33043    33047     +4     
  Branches     7661     7422   -239     
========================================
+ Hits        31590    31594     +4     
  Misses       1400     1400            
  Partials       53       53            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

3 participants