fix: gate studio home roles and permissions button on authz waffle flag#3072
fix: gate studio home roles and permissions button on authz waffle flag#3072Anas12091101 wants to merge 1 commit into
Conversation
|
Thanks for the pull request, @Anas12091101! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3072 +/- ##
========================================
Coverage 95.60% 95.60%
========================================
Files 1391 1391
Lines 33043 33047 +4
Branches 7661 7422 -239
========================================
+ Hits 31590 31594 +4
Misses 1400 1400
Partials 53 53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
The "Roles and permissions" button on the Studio Home page was unconditionally rendered for all active users, regardless of whether the
authz.enable_course_authoringwaffle flag was enabled.The button is now gated on both
enableAuthzCourseAuthoringwaffle flag andADMIN_CONSOLE_URLbeing configured, consistent with how the course-level settings menu already behaves. Tests have been updated to cover both the enabled and disabled states.Useful information to include:
Before

After

Supporting information
https://github.com/mitodl/hq/issues/11519
Testing instructions
Enable the
authz.enable_course_authoringwaffle flag in Django Admin → Waffle → Flags and ensureADMIN_CONSOLE_URLis set in the MFE config. Navigate to Studio Home and verify that the "Roles and permissions" button appears in the header.Disable the flag (or leave it unset) and verify the "Roles and permissions" button is not present on Studio Home.
Other information
Include anything else that will help reviewers and consumers understand the change.
Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'