feat: make new unit outline design default and sidebar design fixes backport#3082
feat: make new unit outline design default and sidebar design fixes backport#3082rpenido wants to merge 4 commits into
Conversation
…t Experiments [FC-0123] (openedx#3034) This PR sets the default value of `ENABLE_UNIT_PAGE_NEW_DESIGN` to `true`, and fix some issues with the `Content Experiments` xblock with the new sidebar.
|
Thanks for the pull request, @rpenido! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/verawood #3082 +/- ##
===================================================
Coverage ? 95.52%
===================================================
Files ? 1392
Lines ? 32915
Branches ? 7591
===================================================
Hits ? 31441
Misses ? 1406
Partials ? 68 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
navinkarkera
left a comment
There was a problem hiding this comment.
@rpenido Looks good. I am assuming that the sidebar should not be sticky when ENABLE_UNIT_PAGE_NEW_DESIGN is false as this is the behavior in master too.
I just have one suggestion, can you use -x option when cherry picking these commits. It adds a nice reference link back to original commit.
Description
Backport of #3034, #3055, #3056, and #3057
Supporting information
Testing instructions
npm run buildenv.config.jsxto see the behavior with insert/wrapping components:Note: The flex classes in the wrapping divs are necessary so the content adapts to the remaining space correctly.
100vhand occupies the whole left while scrolling.ENABLE_UNIT_PAGE_NEW_DESIGNset to bothtrueandfalse.Best Practices Checklist
We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:
.ts,.tsx).propTypesanddefaultPropsin any new or modified code.src/testUtils.tsx(specificallyinitializeMocks)apiHooks.tsin this repo for examples.messages.tsfiles have adescriptionfor translators to use.../in import paths. To import from parent folders, use@src, e.g.import { initializeMocks } from '@src/testUtils';instead offrom '../../../../testUtils'