Skip to content

refactor: remove useNewVideoUploadsPage waffle flag#3106

Closed
farhan wants to merge 1 commit into
openedx:masterfrom
farhan:remove-useNewVideoUploadsPage
Closed

refactor: remove useNewVideoUploadsPage waffle flag#3106
farhan wants to merge 1 commit into
openedx:masterfrom
farhan:remove-useNewVideoUploadsPage

Conversation

@farhan

@farhan farhan commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

🛑 Closed without merging. Removing this flag is on hold pending the upstream feature decision in openedx/openedx-platform#37972.

openedx/openedx-platform#37582 (merged) removed the legacy video page but deliberately kept contentstore.new_studio_mfe.use_new_video_uploads_page to keep the new page flagged off for the community (both versions only work on edx.org). Removing the MFE read now would un-gate an edX/MIT-only feature for community installs. Two of #37972's three possible outcomes (remove the page / genericize with plugin slots) would make this PR the wrong change.

Full context and grooming notes: #3105. Will revisit once #37972 lands a decision.


Closes #3105 (deferred — see above)

Description

Removes the useNewVideoUploadsPage waffle flag and keep it enabled by default.

References

Removes the useNewVideoUploadsPage waffle flag and collapses its
gated branches: the VideoSettingsModal "Replace video" button now
renders whenever the editor is not in a library, and the content
dropdown "Videos" link is governed solely by the
ENABLE_VIDEO_UPLOAD_PAGE_LINK_IN_CONTENT_DROPDOWN env config.

Deferred from openedx#3063 and split out of openedx#3069 because this is a
feature flag (edX/MIT-specific videos page), not an MFE-vs-legacy
routing flag. See openedx#3105.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@farhan farhan marked this pull request as draft June 21, 2026 11:15
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.57%. Comparing base (6b03394) to head (aab3b90).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3106      +/-   ##
==========================================
- Coverage   95.57%   95.57%   -0.01%     
==========================================
  Files        1403     1403              
  Lines       33294    33292       -2     
  Branches     7811     7803       -8     
==========================================
- Hits        31822    31820       -2     
  Misses       1406     1406              
  Partials       66       66              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@farhan

farhan commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Closing — flag removal is on hold pending the upstream decision in openedx/openedx-platform#37972. Full reasoning in #3105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove useNewVideoUploadsPage waffle flag (deferred from #3063)

1 participant