fix: add background to intro-video-button play icon for contrast#133
Open
brian-smith-tcril wants to merge 1 commit into
Open
fix: add background to intro-video-button play icon for contrast#133brian-smith-tcril wants to merge 1 commit into
brian-smith-tcril wants to merge 1 commit into
Conversation
The PlayCircleFilledWhite icon disappears over light course images. Adding `bg-primary rounded-circle` gives it a solid circular background so it stays visible regardless of the course image. Closes openedx#132 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
brian-smith-tcril
added
the
create-sandbox
brian-smith-tcril
added a commit
to brian-smith-tcril/frontend-app-catalog
that referenced
this pull request
Jul 8, 2026
Same fix as openedx#133 against master, ported to the frontend-base placeholder slot so the icon is visible on light course images here too. Refs openedx#132 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlayCircleFilledWhiteicon on the Course About intro video button becomes hard to see over light course images (issue CourseAboutIntroVideoButton Icon barely visible over light course images #132).bg-primary rounded-circleto the icon'sclassNameso the icon has a solid circular background and stays visible against any image.Closes #132.
Screenshots
Before:
After:
Test plan
🤖 Generated with Claude Code