Skip to content

Commit f12364f

Browse files
arbrandesclaude
andcommitted
feat: opt into the course bar
Declares the instructor-dashboard's route role under the providesCourseBarRolesId and providesCourseBarMasqueradeRolseId so the shell's course bar renders on this app's routes. Also add the new `cmsBaseUrl`, used by the masquerade bar to display the Studio link. Finally, fix up the external route roles in the site.config. Co-Authored-By: Claude <noreply@anthropic.com>
1 parent 9ffd17a commit f12364f

5 files changed

Lines changed: 12 additions & 8 deletions

File tree

package-lock.json

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

site.config.ci.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ const siteConfig: SiteConfig = {
99
siteName: 'Instructor CI',
1010
baseUrl: 'http://apps.local.openedx.io',
1111
lmsBaseUrl: 'http://local.openedx.io',
12+
cmsBaseUrl: 'http://studio.local.openedx.io',
1213
loginUrl: 'http://local.openedx.io/login',
1314
logoutUrl: 'http://local.openedx.io/logout',
1415

site.config.dev.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ const siteConfig: SiteConfig = {
99
siteName: 'Instructor Dev',
1010
baseUrl: 'http://apps.local.openedx.io:8080',
1111
lmsBaseUrl: 'http://local.openedx.io:8000',
12+
cmsBaseUrl: 'http://studio.local.openedx.io:8001',
1213
loginUrl: 'http://local.openedx.io:8000/login',
1314
logoutUrl: 'http://local.openedx.io:8000/logout',
1415

@@ -21,15 +22,15 @@ const siteConfig: SiteConfig = {
2122
],
2223
externalRoutes: [
2324
{
24-
role: 'profile',
25+
role: 'org.openedx.frontend.role.profile',
2526
url: 'http://apps.local.openedx.io:1995/profile/'
2627
},
2728
{
28-
role: 'account',
29+
role: 'org.openedx.frontend.role.account',
2930
url: 'http://apps.local.openedx.io:1997/account/'
3031
},
3132
{
32-
role: 'logout',
33+
role: 'org.openedx.frontend.role.logout',
3334
url: 'http://local.openedx.io:8000/logout'
3435
},
3536
],

site.config.test.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ const siteConfig: SiteConfig = {
55
siteName: 'Instructor Test Site',
66
baseUrl: 'http://localhost:8080',
77
lmsBaseUrl: 'http://localhost:8000',
8+
cmsBaseUrl: 'http://localhost:8001',
89
loginUrl: 'http://localhost:8000/login',
910
logoutUrl: 'http://localhost:8000/logout',
1011

src/provides.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
import { providesCourseNavigationRolesId } from '@openedx/frontend-base';
1+
import { providesCourseBarMasqueradeRolesId, providesCourseBarRolesId } from '@openedx/frontend-base';
22
import { instructorDashboardRole } from './constants';
33

44
const provides = {
5-
[providesCourseNavigationRolesId]: instructorDashboardRole
5+
[providesCourseBarRolesId]: instructorDashboardRole,
6+
[providesCourseBarMasqueradeRolesId]: instructorDashboardRole,
67
};
78

89
export default provides;

0 commit comments

Comments
 (0)