Skip to content

Special Exams allowances#146

Merged
diana-villalvazo-wgu merged 2 commits into
openedx:mainfrom
WGU-Open-edX:88/allowances
Apr 27, 2026
Merged

Special Exams allowances#146
diana-villalvazo-wgu merged 2 commits into
openedx:mainfrom
WGU-Open-edX:88/allowances

Conversation

@diana-villalvazo-wgu

@diana-villalvazo-wgu diana-villalvazo-wgu commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Description

As part of this PR we added all the functionality to Allowances Tab inside Special Exams Instructor Tab, you will be allowed to:

  • See allowances table list
  • Filter table by username or email
  • Add new allowance
  • Edit allowance
  • Delete allowance

Supporting information

Closes #88

Testing instructions

  • Go to special exams tab
  • Click on Allowances tab
  • You should see the allowances table, add button, if you have allowances on the list you can see the actions 3 dot icon to display menu for edit or delete

Other information

Screenshot 2026-04-26 at 12 42 59 p m Screenshot 2026-04-26 at 12 47 11 p m Screenshot 2026-04-26 at 12 46 57 p m Screenshot 2026-04-26 at 12 43 29 p m

LLM usage notice

Unit tests built with assistance from Claude.

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 6, 2026
@openedx-webhooks

openedx-webhooks commented Apr 6, 2026

Copy link
Copy Markdown

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instructor-dashboard.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Apr 6, 2026
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Apr 6, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 6, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 88/allowances branch 2 times, most recently from 9bb2152 to e053349 Compare April 9, 2026 23:12
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 88/allowances branch 8 times, most recently from f13ddca to 3a0d168 Compare April 22, 2026 18:46
@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.40102% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.22%. Comparing base (f1e6fec) to head (090a296).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/specialExams/components/EditAllowanceModal.tsx 80.64% 6 Missing ⚠️
src/specialExams/components/AllowancesList.tsx 88.00% 3 Missing ⚠️
src/specialExams/components/AddAllowanceModal.tsx 95.91% 2 Missing ⚠️
...c/specialExams/components/DeleteAllowanceModal.tsx 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
+ Coverage   88.78%   89.22%   +0.44%     
==========================================
  Files         133      138       +5     
  Lines        2006     2190     +184     
  Branches      411      444      +33     
==========================================
+ Hits         1781     1954     +173     
- Misses        219      230      +11     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 88/allowances branch 12 times, most recently from f100f63 to aff1952 Compare April 26, 2026 18:05
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the 88/allowances branch 2 times, most recently from 4fa49a6 to a30cc26 Compare April 26, 2026 18:42
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review April 26, 2026 18:52
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Apr 26, 2026

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just one concern about a possible query key bug

Comment thread src/specialExams/data/queryKeys.ts Outdated
@diana-villalvazo-wgu diana-villalvazo-wgu merged commit a8a02ec into openedx:main Apr 27, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 27, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the 88/allowances branch April 27, 2026 15:06
@openedx-semantic-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Ticket - Allowances

5 participants