fix!: adapt to upstream features: data shape change#153
Merged
Conversation
diana-villalvazo-wgu
approved these changes
Apr 9, 2026
Contributor
|
will merge once frontend base is updated (when related PR is merged) |
arbrandes
force-pushed
the
simplified-navbar-provides
branch
2 times, most recently
from
cff349e to
b584ff9
Compare
arbrandes
changed the title
features: data shape change
arbrandes
force-pushed
the
simplified-navbar-provides
branch
from
b584ff9 to
5ff086a
Compare
arbrandes
force-pushed
the
simplified-navbar-provides
branch
from
fce4609 to
6d94b75
Compare
Adapts to the upstream rename of the provides constant and the flat string data shape. Removes the messages export from index.ts since translations are handled at the site level. BREAKING CHANGE: public identifiers now use `instructorDashboard` instead of `instructor`. Co-Authored-By: Claude <noreply@anthropic.com>
arbrandes
force-pushed
the
simplified-navbar-provides
branch
from
6d94b75 to
9e2a277
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 81.89% 81.83% -0.06%
==========================================
Files 87 88 +1
Lines 1121 1123 +2
Branches 240 256 +16
==========================================
+ Hits 918 919 +1
+ Misses 198 197 -1
- Partials 5 7 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.0.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adapts to the upstream breaking change in frontend-base where the provides constant was renamed to
providesCourseNavigationRolesIdand the data shape changed from{ courseNavigationRoles: string[] }to a flatstring[]. Extracts the provides config into its own module using the upstream constant.Renames all public-facing identifiers (appId, role, route/slot/widget IDs, and exported names) from
instructortoinstructorDashboardfor consistency.Removes the
instructorDashboardMessagesexport fromindex.ts, since translations are handled at the site level viasite.i18nand the export breaks when the compileddist/is consumed by a site.Depends on openedx/frontend-base#220.
LLM usage notice
Built with assistance from Claude.