feat: package and component to render grading configuration#188
Conversation
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @jesusbalderramawgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
+ Coverage 88.70% 89.89% +1.19%
==========================================
Files 133 139 +6
Lines 1992 2277 +285
Branches 429 459 +30
==========================================
+ Hits 1767 2047 +280
- Misses 219 224 +5
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <h3>{intl.formatMessage(messages.gradingConfiguration)}</h3> | ||
| <ModalDialog size="lg" title={intl.formatMessage(messages.gradingConfiguration)} isOpen={isOpen} onClose={onClose} isOverflowVisible={false}> | ||
| <ModalDialog.Header className="px-0"> | ||
| <h3 className="border-bottom pb-3 px-4 mb-3 text-primary"> |
There was a problem hiding this comment.
class should be text-primary-500
There was a problem hiding this comment.
Adding there the border button will create some issues, pls follow styling similar like this modal to display correctly the borders also you are missing the border below the body/above footer
src/dateExtensions/components/AddExtensionModal.tsx
There was a problem hiding this comment.
let me check that second comment
There was a problem hiding this comment.
I have updated the PR
diana-villalvazo-wgu
added
the
mao-onboarding
|
🎉 This PR is included in version 1.0.0-alpha.30 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Description
Grading configuration modal needs render the data correctly
this is part of the this issue
change
Codemirror package added and component created to render this data correctly.
screenshots