Skip to content

fix: Multiple bug fixes#189

Merged
diana-villalvazo-wgu merged 4 commits into
openedx:mainfrom
WGU-Open-edX:fixes
Apr 28, 2026
Merged

fix: Multiple bug fixes#189
diana-villalvazo-wgu merged 4 commits into
openedx:mainfrom
WGU-Open-edX:fixes

Conversation

@diana-villalvazo-wgu

@diana-villalvazo-wgu diana-villalvazo-wgu commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Description

As part of this PR were addressed following fixes:

  • Remove duplicated reset attempts button on Grading Tab.
  • If a user is inactive and you add it as a beta tester a warning alert should be displayed.
  • Add tooltip and don't allow users to edit roles that are not allowed, for example Admins can't remove their own admin role, Discussion Admins can't modify roles different than TA and Discussion roles.

Supporting information

Closes #187
Closes #161

Testing instructions

Screenshots

  • Remove duplicated reset attempts button on Grading Tab.
    Before
Screenshot 2026-04-28 at 9 25 52 a m

After
Screenshot 2026-04-28 at 9 26 35 a m

  • Add tooltip and don't allow users to edit roles that are not allowed, for example Admins can't remove their own admin role, Discussion Admins can't modify roles different than TA and Discussion roles.
Screenshot 2026-04-28 at 9 32 13 a m Screenshot 2026-04-28 at 9 32 23 a m Screenshot 2026-04-28 at 9 32 31 a m

Best Practices Checklist

We're trying to move away from some deprecated patterns in this codebase. Please
check if your PR meets these recommendations before asking for a review:

  • Any new files are using TypeScript (.ts, .tsx).
  • Deprecated propTypes, defaultProps, and injectIntl patterns are not used in any new or modified code.
  • Tests should use the helpers in src/testUtils.tsx (specifically initializeMocks)
  • Use React Query to load data from REST APIs. See any apiHooks.ts in this repo for examples.
  • All new i18n messages in messages.ts files have a description for translators to use.
  • Imports avoid using ../. To import from parent folders, use @src, e.g. import { initializeMocks } from '@src/testUtils'; instead of from '../../../../testUtils'

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Apr 28, 2026
@openedx-webhooks

openedx-webhooks commented Apr 28, 2026

Copy link
Copy Markdown

Thanks for the pull request, @diana-villalvazo-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instructor-dashboard.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Apr 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.96%. Comparing base (8532409) to head (f10b5e8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   89.89%   89.96%   +0.06%     
==========================================
  Files         139      139              
  Lines        2277     2291      +14     
  Branches      459      495      +36     
==========================================
+ Hits         2047     2061      +14     
+ Misses        224      222       -2     
- Partials        6        8       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/courseTeam/data/apiHook.ts Outdated

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@diana-villalvazo-wgu diana-villalvazo-wgu merged commit 6efc53a into openedx:main Apr 28, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Apr 28, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the fixes branch April 28, 2026 21:48
@openedx-semantic-release-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

brian-smith-tcril pushed a commit to brian-smith-tcril/frontend-app-instructor-dashboard that referenced this pull request Apr 29, 2026
* fix: remove duplicated reset button

* fix: add inactive message for beta testers inactive user

* fix: add validation for roles that can't be edited by current user

* fix: add editableroles to querykey
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U released on @latest

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Discussion Admin Role Validation Fix: Enrollment and Beta Tester actions failing for learner type users

4 participants