feat: register help button in the header#191
Open
brian-smith-tcril wants to merge 1 commit intoopenedx:mainfrom
Open
feat: register help button in the header#191brian-smith-tcril wants to merge 1 commit intoopenedx:mainfrom
brian-smith-tcril wants to merge 1 commit intoopenedx:mainfrom
Conversation
348410f to
9b87e55
Compare
diana-villalvazo-wgu
approved these changes
Apr 29, 2026
Calls frontend-base's helpButtonSlotOperation to surface a Help link in the header for instructor-dashboard routes, gated on the instructor-dashboard role. The URL comes from getAppConfig().SUPPORT_URL, which the backend resolves via MFE_CONFIG / MFE_CONFIG_OVERRIDES or the help-tokens legacy fallback. Refs openedx/frontend-base#245 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
9b87e55 to
eb768b6
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #191 +/- ##
==========================================
+ Coverage 89.89% 89.96% +0.06%
==========================================
Files 139 139
Lines 2277 2291 +14
Branches 459 495 +36
==========================================
+ Hits 2047 2061 +14
+ Misses 224 222 -2
- Partials 6 8 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Should we ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion PR to openedx/frontend-base#251. Registers a help button in the header for instructor-dashboard via the new
helpButtonSlotOperationhelper from frontend-base.The URL comes from
getAppConfig(instructorDashboardAppId).SUPPORT_URLat render time. In production it's populated via the backend's frontend site config API:MFE_CONFIG_OVERRIDES.instructor-dashboard.SUPPORT_URLif set, elsehelp-tokenslegacy fallback (resolved per-app on the backend), elsecommonAppConfig.SUPPORT_URLas a final fallback.If none are set, the button doesn't render — matching the existing learner-dashboard behavior.
This PR depends on openedx/frontend-base#251 — do not merge before that.
Test plan
nvm use && npm run test— full suite greencommonAppConfig.SUPPORT_URLand verify the Help link appears in the header on instructor-dashboard routes🤖 Generated with Claude Code