fix: set document title via Helmet on the dashboard route#192
Merged
Conversation
Adopt the per-page document title pattern from frontend-base ADR 0015, so the browser tab no longer keeps the previous app's title (commonly "Login | <site>" after sign-in via authn). Refs openedx/frontend-base#250. Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 89.96% 90.05% +0.09%
==========================================
Files 139 140 +1
Lines 2291 2293 +2
Branches 499 499
==========================================
+ Hits 2061 2065 +4
+ Misses 222 220 -2
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Brings patch coverage back to 100% on Main.tsx and the new messages.ts by asserting the Helmet-set document title against the test site name. Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
approved these changes
Apr 29, 2026
|
🎉 This PR is included in version 1.0.0-alpha.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs openedx/frontend-base#250.
Adopts the per-page document title pattern set out in frontend-base ADR 0015. Because all frontend-base apps share a single
index.html, the document title only changes if a page sets it. Authn does, but the instructor dashboard didn't, so after navigating in from another app the browser tab kept reading the previous page's title.The dashboard's
Mainroute component now renders a<Helmet>block that sets<title>from a new localized message (instructor-dashboard.page.title, defaultInstructor Dashboard | {siteName}), withsiteNamepulled fromgetSiteConfig()and passed as an i18n parameter so localizers can re-order the segments.react-helmetis added to the app's runtime dependencies.LLM usage notice
Built with assistance from Claude.