Skip to content

feat: opt into the course bar#198

Merged
arbrandes merged 1 commit into
openedx:mainfrom
arbrandes:arbrandes/masquerade-bar
May 6, 2026
Merged

feat: opt into the course bar#198
arbrandes merged 1 commit into
openedx:mainfrom
arbrandes:arbrandes/masquerade-bar

Conversation

@arbrandes
Copy link
Copy Markdown
Contributor

@arbrandes arbrandes commented May 5, 2026

Description

Declares the instructor-dashboard's route role under the providesCourseBarRolesId and providesCourseBarMasqueradeRolesId provides ID so the shell's course bar (including both navigation and masquerade) renders on this app's routes.

Depends on the course bar landing in frontend-base (openedx/frontend-base#260).

LLM usage notice

Built with assistance from Claude.

@arbrandes arbrandes marked this pull request as draft May 6, 2026 11:21
@arbrandes arbrandes force-pushed the arbrandes/masquerade-bar branch from c993c5a to 82eac75 Compare May 6, 2026 13:12
@arbrandes arbrandes changed the title feat: opt into the masquerade bar slot feat: opt into the course bar May 6, 2026
@arbrandes arbrandes force-pushed the arbrandes/masquerade-bar branch 3 times, most recently from f667059 to f12364f Compare May 6, 2026 21:37
@arbrandes arbrandes marked this pull request as ready for review May 6, 2026 21:38
Declares the instructor-dashboard's route role under the
providesCourseBarRolesId and providesCourseBarMasqueradeRolseId so the
shell's course bar renders on this app's routes.

Also add the new `cmsBaseUrl`, used by the masquerade bar to display the
Studio link.

Finally, fix up the external route roles in the site.config.

Co-Authored-By: Claude <noreply@anthropic.com>
@arbrandes arbrandes force-pushed the arbrandes/masquerade-bar branch from f12364f to 02a4a60 Compare May 6, 2026 21:48
@arbrandes arbrandes merged commit 75edc10 into openedx:main May 6, 2026
4 checks passed
@arbrandes arbrandes deleted the arbrandes/masquerade-bar branch May 6, 2026 21:55
@openedx-semantic-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.36 🎉

The release is available on:

Your semantic-release bot 📦🚀

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (9ffd17a) to head (02a4a60).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #198   +/-   ##
=======================================
  Coverage   90.28%   90.28%           
=======================================
  Files         141      141           
  Lines        2408     2408           
  Branches      521      490   -31     
=======================================
  Hits         2174     2174           
- Misses        226      228    +2     
+ Partials        8        6    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants