Skip to content

enrollment summary section#54

Merged
diana-villalvazo-wgu merged 5 commits into
openedx:mainfrom
WGU-Open-edX:enrollment-summary
Mar 3, 2026
Merged

enrollment summary section#54
diana-villalvazo-wgu merged 5 commits into
openedx:mainfrom
WGU-Open-edX:enrollment-summary

Conversation

@jacobo-dominguez-wgu

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Oct 24, 2025

Copy link
Copy Markdown
Contributor

Description

Adding the course enrollment summary section.
Splitted the code in different components in order to enhance reusability, testability and readbility of the code.
I have used copilot to generate the unit tests, and I have supervised them to be correct and useful.

It closes #25
Figma design: https://www.figma.com/design/RnkfsNvyutLkSDXEhEOkEY/Instructor-Experience?node-id=18471-191211&t=ISjOGICChS4uRnek-11

Screenshot

Captura de pantalla 2025-10-24 a la(s) 11 45 43 a m

How to test it

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 24, 2025
@openedx-webhooks

openedx-webhooks commented Oct 24, 2025

Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instruct.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Oct 24, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.48%. Comparing base (5b0d465) to head (55d5a9b).
⚠️ Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
...components/generalCourseInfo/GeneralCourseInfo.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #54       +/-   ##
==========================================
+ Coverage   0.00%   81.48%   +81.48%     
==========================================
  Files          5       68       +63     
  Lines          7      864      +857     
  Branches       0      186      +186     
==========================================
+ Hits           0      704      +704     
- Misses         7      157      +150     
- Partials       0        3        +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu moved this from Needs Triage to Waiting on Author in Contributions Oct 24, 2025
Comment thread src/courseInfo/components/EnrollmentSummary/EnrollmentCounter.test.tsx Outdated
Comment thread src/courseInfo/components/EnrollmentSummary/EnrollmentCounter.test.tsx Outdated
@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Oct 31, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu force-pushed the enrollment-summary branch 4 times, most recently from 656dc00 to 8c9a8df Compare October 31, 2025 19:38
@diana-villalvazo-wgu

Copy link
Copy Markdown
Contributor

can you rebase and resolve conflicts pls? @jacobo-dominguez-wgu

@openedx-webhooks openedx-webhooks added the core contributor PR author is a Core Contributor (who may or may not have write access to this repo). label Jan 5, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu force-pushed the enrollment-summary branch 2 times, most recently from 563dec7 to b25c171 Compare February 19, 2026 22:26
@diana-villalvazo-wgu diana-villalvazo-wgu marked this pull request as ready for review March 3, 2026 18:31
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Mar 3, 2026

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good. Just a few concerns

Comment thread src/courseInfo/components/EnrollmentSummary/utils.ts Outdated
/>
<div className="h-auto border-light-400 border-left align-self-stretch" />
{
Object.entries(enrollmentCounts).map(([type, count]) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small issues here: count is already formatted via toLocaleString() before being passed to EnrollmentCounter, which then runs formatNumberWithCommas on it again - it is worth consolidating formatting to one place. Also worth a comment on the messages[type] lookup since any enrollment mode the backend returns that isn't defined in messages.ts will silently fall back to the raw key as its display label.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah regarding messages[type] i added that fallback because i don't know if operators can have custom modes, and if we don't add a fallback it will fail or cause errors, so i thought showing the key could be enough for displaying it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and i had to add the toLocaleString because enrollment counter expects a string and from backend we receive a number, maybe i can change types, working on it

Comment thread src/courseInfo/components/EnrollmentSummary/EnrollmentSummary.tsx Outdated
@diana-villalvazo-wgu diana-villalvazo-wgu self-requested a review March 3, 2026 20:58

@wgu-jesse-stewart wgu-jesse-stewart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - thanks for updating

@diana-villalvazo-wgu diana-villalvazo-wgu merged commit d9eb51c into openedx:main Mar 3, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Mar 3, 2026
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the enrollment-summary branch March 3, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Ticket -Display Enrollment Summary

4 participants