General course info card created#61
Conversation
|
Thanks for the pull request, @jacobo-dominguez-wgu! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
f34a6cb to
649c5a8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61 +/- ##
==========================================
+ Coverage 0.00% 78.94% +78.94%
==========================================
Files 5 14 +9
Lines 7 57 +50
Branches 0 17 +17
==========================================
+ Hits 0 45 +45
- Misses 7 12 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7606842 to
49a27bc
Compare
49a27bc to
0f8527a
Compare
|
can you rebase main please? 😄 |
…nstruct into general-course-info
6e99c88 to
f732e28
Compare
f732e28 to
ab68a47
Compare
ab68a47 to
1302302
Compare
1302302 to
df502cd
Compare
| @@ -0,0 +1,72 @@ | |||
| import { Card, Skeleton } from '@openedx/paragon'; | |||
| import { StatusBadge } from './StatusBadge'; | |||
| import { useCourseInfo } from '../../../data/apiHook'; | |||
There was a problem hiding this comment.
[nit] Shouldn't we avoid this kind of imports in favor of something like @src/...? Like it's done in frontend-authoring? here is an example: https://github.com/openedx/frontend-app-authoring/blob/master/src/authz/data/apiHooks.ts#L2
There was a problem hiding this comment.
Yes, but we have not set the alias settings yet. I tried doing the same than in authoring but it did not work so maybe there is an issue in frontend-base related to it. We need to create a ticket to address it.
There was a problem hiding this comment.
Could you create the ticket please? thanks!
| children: [ | ||
| { | ||
| path: 'course_info', | ||
| path: '/:courseId/course_info', |
There was a problem hiding this comment.
with the updates on base branch it seems :courseId is duplicated here
Description
Adding the general course info card, the components for the card were created and also the rect query hook to fetch the required data.
The unit test were created with the assistance of github copilot and supervised to ensure they work well and are useful.
It closes #24
Figma design: https://www.figma.com/design/RnkfsNvyutLkSDXEhEOkEY/Instructor-Experience?node-id=18416-125046&t=Puj6PbVLRMXDgVDK-0
It depends on: openedx/openedx-platform#37588
Warning
There is a field for
course runmissing on the api response, added a comment here to notify it openedx/openedx-platform#37465 (comment). If the field is missing a NOT SET fallback message is shownScreenshot
LOADED:

LOADING:

How to test it
npm install && npm run dev