Skip to content

General course info card created#61

Merged
diana-villalvazo-wgu merged 6 commits into
openedx:mainfrom
WGU-Open-edX:general-course-info
Dec 5, 2025
Merged

General course info card created#61
diana-villalvazo-wgu merged 6 commits into
openedx:mainfrom
WGU-Open-edX:general-course-info

Conversation

@jacobo-dominguez-wgu

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Description

Adding the general course info card, the components for the card were created and also the rect query hook to fetch the required data.
The unit test were created with the assistance of github copilot and supervised to ensure they work well and are useful.

It closes #24
Figma design: https://www.figma.com/design/RnkfsNvyutLkSDXEhEOkEY/Instructor-Experience?node-id=18416-125046&t=Puj6PbVLRMXDgVDK-0

It depends on: openedx/openedx-platform#37588

Warning

There is a field for course run missing on the api response, added a comment here to notify it openedx/openedx-platform#37465 (comment). If the field is missing a NOT SET fallback message is shown

Screenshot

LOADED:
image

LOADING:
image

How to test it

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 31, 2025
@openedx-webhooks

openedx-webhooks commented Oct 31, 2025

Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend-app-instruct.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Oct 31, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Oct 31, 2025
@jacobo-dominguez-wgu jacobo-dominguez-wgu force-pushed the general-course-info branch 3 times, most recently from f34a6cb to 649c5a8 Compare October 31, 2025 18:51
@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.94%. Comparing base (5b0d465) to head (8089753).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...components/generalCourseInfo/GeneralCourseInfo.tsx 95.45% 1 Missing ⚠️
src/providers/QueryProvider.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            main      #61       +/-   ##
==========================================
+ Coverage   0.00%   78.94%   +78.94%     
==========================================
  Files          5       14        +9     
  Lines          7       57       +50     
  Branches       0       17       +17     
==========================================
+ Hits           0       45       +45     
- Misses         7       12        +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jacobo-dominguez-wgu jacobo-dominguez-wgu force-pushed the general-course-info branch 3 times, most recently from 7606842 to 49a27bc Compare October 31, 2025 20:16
@diana-villalvazo-wgu

Copy link
Copy Markdown
Contributor

can you rebase main please? 😄

@jacobo-dominguez-wgu jacobo-dominguez-wgu marked this pull request as ready for review November 26, 2025 18:14
Comment thread src/courseInfo/components/generalCourseInfo/GeneralCourseInfo.test.tsx Outdated
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Waiting on Author to Ready for Review in Contributions Nov 26, 2025
Comment thread src/courseInfo/components/generalCourseInfo/GeneralCourseInfo.test.tsx Outdated
Comment thread src/data/api.ts

@diana-villalvazo-wgu diana-villalvazo-wgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@jesusbalderramawgu jesusbalderramawgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -0,0 +1,72 @@
import { Card, Skeleton } from '@openedx/paragon';
import { StatusBadge } from './StatusBadge';
import { useCourseInfo } from '../../../data/apiHook';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] Shouldn't we avoid this kind of imports in favor of something like @src/...? Like it's done in frontend-authoring? here is an example: https://github.com/openedx/frontend-app-authoring/blob/master/src/authz/data/apiHooks.ts#L2

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but we have not set the alias settings yet. I tried doing the same than in authoring but it did not work so maybe there is an issue in frontend-base related to it. We need to create a ticket to address it.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create the ticket please? thanks!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the ticket #76

@rodmgwgu rodmgwgu left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

Comment thread src/routes.tsx Outdated
children: [
{
path: 'course_info',
path: '/:courseId/course_info',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the updates on base branch it seems :courseId is duplicated here

@diana-villalvazo-wgu diana-villalvazo-wgu enabled auto-merge (squash) December 5, 2025 14:22
@diana-villalvazo-wgu diana-villalvazo-wgu merged commit 5ce5a16 into openedx:main Dec 5, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this from Ready for Review to Done in Contributions Dec 5, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu deleted the general-course-info branch December 5, 2025 14:24
@diana-villalvazo-wgu diana-villalvazo-wgu removed the request for review from wgu-jesse-stewart January 21, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Ticket - View General Course Information

6 participants