test: fixing test types and handling incorrect props dont match signature

Author: jacobo-dominguez-wgu

src/containers/EmailSettingsModal/hooks.js

@@ -20,7 +20,7 @@ export const useEmailData = ({
   const { mutate: updateEmailSettings } = useUpdateEmailSettings();
   const onToggle = () => setIsOptedOut(!isOptedOut);
   const save = () => {
-    updateEmailSettings(cardId, !isOptedOut);
+    updateEmailSettings({ courseId: cardId, enable: !isOptedOut });
     closeModal();
   };
 

src/containers/EmailSettingsModal/hooks.test.js

@@ -62,7 +62,8 @@ describe('EmailSettingsModal hooks', () => {
     describe('save', () => {
       it('calls updateEmailSettings', () => {
         out.save();
-        expect(updateEmailSettings).toHaveBeenCalledWith(cardId, !out.isOptedOut);
+        const expectedArg = { courseId: cardId, enable: !out.isOptedOut };
+        expect(updateEmailSettings).toHaveBeenCalledWith(expectedArg);
       });
       it('calls closeModal', () => {
         out.save();

src/utils/dataTransformers.test.ts

@@ -15,9 +15,12 @@ Object.defineProperty(window, 'location', {
 });
 
 // Mock URLSearchParams constructor
-global.URLSearchParams = jest.fn().mockImplementation(() => ({
-  get: mockGet,
-}));
+Object.defineProperty(globalThis, 'URLSearchParams', {
+  value: jest.fn().mockImplementation(() => ({
+    get: mockGet,
+  })),
+  writable: true,
+});
 
 type VisibleListResult = {
   visibleList: Array<{

tsconfig.json

@@ -1,6 +1,7 @@
 {
   "extends": "@edx/typescript-config",
   "compilerOptions": {
+    "types": ["jest", "@testing-library/jest-dom"],
     "jsx": "react-jsx",
     "allowJs": true,
     "allowSyntheticDefaultImports": true,