Skip to content

Commit 5e69cf8

Browse files
authored
fix: baseAppUrl wrapping links (#813)
1 parent 09e0260 commit 5e69cf8

3 files changed

Lines changed: 6 additions & 4 deletions

File tree

src/containers/CourseCard/components/CourseCardActions/ResumeButton.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import PropTypes from 'prop-types';
44
import { useIntl } from '@edx/frontend-platform/i18n';
55

66
import { EXECUTIVE_EDUCATION_COURSE_MODES } from 'data/constants/course';
7+
import { baseAppUrl } from 'data/services/lms/urls';
78
import track from 'tracking';
89
import { useCourseTrackingEvent, useCourseData } from 'hooks';
910
import { useInitializeLearnerHome } from 'data/hooks';
@@ -26,7 +27,7 @@ export const ResumeButton = ({ cardId }) => {
2627
const handleClick = useCourseTrackingEvent(
2728
track.course.enterCourseClicked,
2829
cardId,
29-
resumeUrl + execEdTrackingParam,
30+
baseAppUrl(resumeUrl) + execEdTrackingParam,
3031
);
3132
return (
3233
<ActionButton

src/containers/CourseCard/components/CourseCardActions/ResumeButton.test.jsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { render, screen } from '@testing-library/react';
22
import userEvent from '@testing-library/user-event';
33
import { IntlProvider } from '@edx/frontend-platform/i18n';
44
import { useCourseTrackingEvent, useCourseData } from 'hooks';
5+
import { baseAppUrl } from 'data/services/lms/urls';
56

67
import track from 'tracking';
78
import useActionDisabledState from '../hooks';
@@ -40,7 +41,7 @@ jest.mock('./ActionButton/hooks', () => jest.fn(() => false));
4041

4142
useCourseData.mockReturnValue({
4243
enrollment: { mode: 'executive-education' },
43-
courseRun: { resumeUrl: 'home-url' },
44+
courseRun: { resumeUrl: '/resume-url' },
4445
});
4546

4647
describe('ResumeButton', () => {
@@ -84,7 +85,7 @@ describe('ResumeButton', () => {
8485
expect(useCourseTrackingEvent).toHaveBeenCalledWith(
8586
track.course.enterCourseClicked,
8687
props.cardId,
87-
`home-url?org_id=${authOrgId}`,
88+
baseAppUrl(`/resume-url?org_id=${authOrgId}`),
8889
);
8990
});
9091
});

src/containers/CourseCard/components/CourseCardBanners/CertificateBanner.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export const CertificateBanner = ({ cardId }) => {
6363
{certificate.certPreviewUrl && (
6464
<>
6565
{' '}
66-
<Hyperlink isInline destination={certificate.certPreviewUrl}>
66+
<Hyperlink isInline destination={baseAppUrl(certificate.certPreviewUrl)}>
6767
{formatMessage(messages.viewCertificate)}
6868
</Hyperlink>
6969
</>

0 commit comments

Comments
 (0)