Description
This is a list of commits on the frontend-base branch that should be considered for backporting to master. They were identified during the PR #801 review.
-
Dashboard test uses hasCourses: false instead of initIsPending: true — the "courses still loading" test in Dashboard/index.test.jsx passes hasCourses: false, but LoadingView actually renders because initIsPending defaults to true. The hasCourses prop is a red herring. The frontend-base branch makes the intent explicit by passing initIsPending: true instead. Fixed in 757064c.
-
Unused react-test-renderer in devDependencies — react-test-renderer is listed in package.json but is never imported anywhere. It is also deprecated and incompatible with React 19. The frontend-base branch drops it as part of ace3a08.
Description
This is a list of commits on the
frontend-basebranch that should be considered for backporting tomaster. They were identified during the PR #801 review.Dashboard test uses
hasCourses: falseinstead ofinitIsPending: true— the "courses still loading" test inDashboard/index.test.jsxpasseshasCourses: false, but LoadingView actually renders becauseinitIsPendingdefaults totrue. ThehasCoursesprop is a red herring. Thefrontend-basebranch makes the intent explicit by passinginitIsPending: trueinstead. Fixed in 757064c.Unused
react-test-rendererin devDependencies —react-test-rendereris listed inpackage.jsonbut is never imported anywhere. It is also deprecated and incompatible with React 19. Thefrontend-basebranch drops it as part of ace3a08.