fix: remove learnerDashboardMessages export from index.ts#826
Merged
arbrandes merged 1 commit intoApr 9, 2026
Merged
Conversation
The old App.messages pattern included apps exporting their messages via \`src/index.ts\`. There is no reason for apps to export this. The file only exists so the app can run as a site with \`npm run dev\`. With frontend-base's i18n pipeline, translations are handled at the site level via \`site.i18n\`. App-only testing didn't catch this because the webpack fallback plugin correctly resolves the missing messages file when \`npm run dev\` is running the app as a site from the repo root (\`src/i18n/\` context). The broken export only surfaces when the compiled \`dist/\` is consumed by a site. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #826 +/- ##
================================================
Coverage ? 90.36%
================================================
Files ? 152
Lines ? 1287
Branches ? 275
================================================
Hits ? 1163
Misses ? 119
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
approved these changes
Apr 9, 2026
|
🎉 This PR is included in version 1.0.0-alpha.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old
App.messagespattern included apps exporting their messages viasrc/index.ts. There is no reason for apps to export this. The file only exists so the app can run as a site withnpm run dev. With frontend-base's i18n pipeline, translations are handled at the site level viasite.i18n.App-only testing didn't catch this because the webpack fallback plugin correctly resolves the missing messages file when
npm run devis running the app as a site from the repo root (src/i18n/context). The broken export only surfaces when the compileddist/is consumed by a site.🤖 Generated with Claude Code