fix: simplify i18n extraction pipeline#812
Merged
brian-smith-tcril merged 1 commit intoMar 27, 2026
Merged
Conversation
frontend-base alpha.16+ outputs translation data directly to src/i18n/transifex_input.json, so the separate i18n.concat step and transifex-utils dependency are no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #812 +/- ##
================================================
Coverage ? 90.36%
================================================
Files ? 152
Lines ? 1287
Branches ? 275
================================================
Hits ? 1163
Misses ? 119
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This PR is included in version 1.0.0-alpha.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
i18n.concatstep frommake extract_translationstransifex_utilsandtransifex_tempMakefile variables@openedx/frontend-basepeer dep to^1.0.0-alpha.16Ports openedx/frontend-app-authn#1656 —
@openedx/frontend-basealpha.16+ outputs translation data directly tosrc/i18n/transifex_input.json, eliminating the need for a separate concat step.Log
Repo:
frontend-app-learner-dashboard— branchsimplify-i18n-extraction(offfrontend-base)Goal: Port openedx/frontend-app-authn#1656 — remove the
i18n.concatstep frommake extract_translationsnow that@openedx/frontend-basealpha.16+ outputs directly tosrc/i18n/transifex_input.json.Changes
Makefile:
transifex_utilsandtransifex_tempvariablesi18n.concattargetrm -rf $(transifex_temp)fromi18n.extractextract_translationsto drop thei18n.concatdependencypackage.json:
@openedx/frontend-basepeer dep:^1.0.0-alpha.14→^1.0.0-alpha.16package-lock.json:
nvm use && npm install(Node v24)Verification
Ran
make extract_translations— succeeded and producedsrc/i18n/transifex_input.json(13K, flat key-value format) without the concat step.Compared output against
masterusingjq -r 'keys[]':masterhaslearner-dash.error-page-message, our branch does notfrontend-basebranch source — it's legitimately absent, not a pipeline bugAlso verified that
make extract_translationson thefrontend-basebranch (without our fix) errors at thei18n.concatstep withError: Found no messages, confirming the fix is necessary.Commit
2e8b1b5— fix: simplify i18n extraction pipeline🤖 Generated with Claude Code