fix: baseAppUrl wrapping links#813
Merged
Merged
Conversation
* fix: Run `npm audit fix` to update dependencies. * chore(deps): update dependency @openedx/paragon to v23.14.9 (#735) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @reduxjs/toolkit to v2.9.1 (#736) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): bump actions/setup-node from 5 to 6 (#737) --------- Co-authored-by: Feanil Patel <feanil@axim.org> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
|
(Though we do need to fix tests, first. :) |
jacobo-dominguez-wgu
approved these changes
Mar 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #813 +/- ##
=======================================
Coverage 98.19% 98.19%
=======================================
Files 145 145
Lines 1388 1388
Branches 298 293 -5
=======================================
Hits 1363 1363
Misses 25 25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
added a commit
to arbrandes/frontend-app-learner-dashboard
that referenced
this pull request
Apr 23, 2026
Ports the CertificateBanner portion of 5e69cf8 (openedx#813). The ResumeButton changes from that commit are already covered by 4a75852. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple spots that were missed in the React Query conversion. Previously, these links were being wrapped when they were set in Redux state.
https://github.com/openedx/frontend-app-learner-dashboard/blob/release/ulmo/src/data/redux/app/selectors/courseCard.js#L31
https://github.com/openedx/frontend-app-learner-dashboard/blob/release/ulmo/src/data/redux/app/selectors/courseCard.js#L58
This PR wraps the links in the components where they are used.