fix: scope header slot widgets to dashboard role#830
Merged
arbrandes merged 1 commit intoApr 13, 2026
Conversation
Fixes openedx#829 Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #830 +/- ##
================================================
Coverage ? 90.37%
================================================
Files ? 152
Lines ? 1288
Branches ? 275
================================================
Hits ? 1164
Misses ? 119
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jesusbalderramawgu
approved these changes
Apr 13, 2026
|
🎉 This PR is included in version 1.0.0-alpha.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an
active: [dashboardRole]condition to all header slot widget operations so they only render when the dashboard route is active. Previously, none of the slot operations were scoped to the dashboard role, meaning they would appear in the header on every page.Also extracts the dashboard role string into a shared
dashboardRoleconstant insrc/constants.ts, replacing the hardcoded values inapp.tsxandroutes.jsx.Fixes #829
LLM usage notice
Built with assistance from Claude.