Skip to content

fix: prepend lmsBaseUrl to relative resumeUrl in ResumeButton#831

Merged
arbrandes merged 1 commit into
openedx:frontend-basefrom
arbrandes:arbrandes/fix-action-button-href-take-2
Apr 13, 2026
Merged

fix: prepend lmsBaseUrl to relative resumeUrl in ResumeButton#831
arbrandes merged 1 commit into
openedx:frontend-basefrom
arbrandes:arbrandes/fix-action-button-href-take-2

Conversation

@arbrandes
Copy link
Copy Markdown
Contributor

Description

When href="#" was replaced with actual URLs in the course action buttons (205cc6b), the ResumeButton's resumeUrl lost its baseAppUrl() wrapping.

LLM usage notice

Built with assistance from Claude.

Co-Authored-By: Claude <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (frontend-base@3c2ccdc). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff                @@
##             frontend-base     #831   +/-   ##
================================================
  Coverage                 ?   90.37%           
================================================
  Files                    ?      152           
  Lines                    ?     1288           
  Branches                 ?      267           
================================================
  Hits                     ?     1164           
  Misses                   ?      119           
  Partials                 ?        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arbrandes arbrandes merged commit 4a75852 into openedx:frontend-base Apr 13, 2026
6 checks passed
@arbrandes arbrandes deleted the arbrandes/fix-action-button-href-take-2 branch April 13, 2026 18:37
@openedx-semantic-release-bot
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0-alpha.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Course action buttons use href="#" instead of the actual destination URL

3 participants